linux-kernel - Re: [PATCH v4 2/7] dt-bindings: phy: samsung,usb3-drd-phy: gs101: require Type-C properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <173393203254.3086087.14024716233496700566.robh@kernel.org>
Date: Wed, 11 Dec 2024 09:47:13 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: André Draszik <andre.draszik@...aro.org>
Cc: Roy Luo <royluo@...gle.com>, Tudor Ambarus <tudor.ambarus@...aro.org>,
	Will McVicker <willmcvicker@...gle.com>,
	linux-phy@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	devicetree@...r.kernel.org,
	Peter Griffin <peter.griffin@...aro.org>,
	linux-samsung-soc@...r.kernel.org,
	Sam Protsenko <semen.protsenko@...aro.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Vinod Koul <vkoul@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	kernel-team@...roid.com, Conor Dooley <conor+dt@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/7] dt-bindings: phy: samsung,usb3-drd-phy: gs101:
 require Type-C properties


On Fri, 06 Dec 2024 16:31:02 +0000, André Draszik wrote:
> orientation-switch is the standard declaration to inform the Type-C mux
> layer that a remote-endpoint is capable of processing orientation
> change messages.
> 
> The USB PHY on gs101 needs to be configured based on the orientation of
> the connector. For that the DTS needs a link between the phy's port and
> a TCPCi, and we'll need to inform the phy driver that it should handle
> the orientation (register a handler).
> 
> Update the schema to enforce that by requiring the orientation-switch
> and port properties on gs101 (only). We disallow orientation-switch on
> all other supported platforms, since other versions of this phy (or its
> system integration) don't currently support or even need it.
> 
> Even though this new required gs101 property is an ABI break, the
> intention for the driver is to behave as before if it's missing
> (meaning for gs101 it will work in SS mode in one orientation only).
> Other platforms are not affected.
> 
> Reviewed-by: Peter Griffin <peter.griffin@...aro.org>
> Signed-off-by: André Draszik <andre.draszik@...aro.org>
> 
> ---
> v3:
> * update as per Rob's suggestion (I hope :-)
> 
> v2:
> * squash original patches #2 and #3
> * actually disallow orientation-switch on !gs101 (not just optional) (Conor)
> * update commit message to clarify that the intention for the driver is
>   to work with old and new DTS (Conor)
> * collect tags
> 
> foo
> ---
>  Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>