linux-kernel - Re: [PATCH v6 1/8] PCI: Don't expose pcie_read_tlp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241211162207.00004bd6@huawei.com>
Date: Wed, 11 Dec 2024 16:22:07 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: <linux-pci@...r.kernel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "Mahesh
 J Salgaonkar" <mahesh@...ux.ibm.com>, Oliver O'Halloran <oohall@...il.com>,
	Lukas Wunner <lukas@...ner.de>, Krzysztof Wilczyński
	<kw@...ux.com>, <linux-kernel@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH v6 1/8] PCI: Don't expose pcie_read_tlp_log() outside of
 PCI subsystem

On Fri, 13 Sep 2024 17:36:25 +0300
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> wrote:

> pcie_read_tlp_log() was exposed by the commit 0a5a46a6a61b ("PCI/AER:
> Generalize TLP Header Log reading") but this is now considered a
> mistake. No drivers outside of PCI subsystem should build their own
> diagnostic logging but should rely on PCI core doing it for them.
> 
> There's currently one driver (ixgbe) doing it independently which was
> the initial reason why the export was added but it was decided by the
> PCI maintainer that it's something that should be eliminated.
> 
> Remove the unwanted EXPORT of pcie_read_tlp_log() and remove it from
> include/linux/aer.h.
> 
> Link: https://lore.kernel.org/all/20240322193011.GA701027@bhelgaas/
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
FWIW LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>