linux-kernel - Re: [PATCH 1/2] cpufreq: amd-pstate: Use CPUFREQ_POLICY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08f23b24-75f4-4d5f-9d54-002e13bca1c9@amd.com>
Date: Wed, 11 Dec 2024 10:37:43 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Christian Loehle <christian.loehle@....com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Huang Rui <ray.huang@....com>, gautham.shenoy@....com,
 Perry Yuan <perry.yuan@....com>, rafael@...nel.org, viresh.kumar@...aro.org
Subject: Re: [PATCH 1/2] cpufreq: amd-pstate: Use CPUFREQ_POLICY_UNKNOWN

On 12/11/2024 06:26, Christian Loehle wrote:
> epp_policy uses the same values as cpufreq_policy.policy and resets
> to CPUFREQ_POLICY_UNKNOWN during offlining. Be consistent about
> it and initialize to CPUFREQ_POLICY_UNKNOWN instead of 0, too.
> 
> No functional change intended.
> 
> Cc: Huang Rui <ray.huang@....com>
> Cc: <gautham.shenoy@....com>
> Cc: Mario Limonciello <mario.limonciello@....com>
> Cc: Perry Yuan <perry.yuan@....com>
> Signed-off-by: Christian Loehle <christian.loehle@....com>
> ---
>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index d7630bab2516..546e69cbdf76 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1449,7 +1449,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   		return -ENOMEM;
>   
>   	cpudata->cpu = policy->cpu;
> -	cpudata->epp_policy = 0;
> +	cpudata->epp_policy = CPUFREQ_POLICY_UNKNOWN;
>   
>   	ret = amd_pstate_init_perf(cpudata);
>   	if (ret)

Hi,

Thanks for the patch.  In this case it's actually not needed though. 
Some of the in-flight content for 6.14 drops that variable.  This is on 
the superm1/linux.git bleeding-edge branch (which content will promote 
to superm1/linux.git linux-next branch soon and eventually come to 
linux-pm).

https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git/commit/?h=bleeding-edge&id=b8321230569dc17852a7f7adc7715ad07538cbeb