linux-kernel - RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for kernel usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6e9c128e888c4cacb04b5dd53b1d1b79@huawei.com>
Date: Wed, 11 Dec 2024 17:58:37 +0000
From: Shiju Jose <shiju.jose@...wei.com>
To: Shiju Jose <shiju.jose@...wei.com>, Dan Williams
	<dan.j.williams@...el.com>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-cxl@...r.kernel.org"
	<linux-cxl@...r.kernel.org>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "bp@...en8.de" <bp@...en8.de>, "tony.luck@...el.com"
	<tony.luck@...el.com>, "rafael@...nel.org" <rafael@...nel.org>,
	"lenb@...nel.org" <lenb@...nel.org>, "mchehab@...nel.org"
	<mchehab@...nel.org>, "dave@...olabs.net" <dave@...olabs.net>, "Jonathan
 Cameron" <jonathan.cameron@...wei.com>, "dave.jiang@...el.com"
	<dave.jiang@...el.com>, "alison.schofield@...el.com"
	<alison.schofield@...el.com>, "vishal.l.verma@...el.com"
	<vishal.l.verma@...el.com>, "ira.weiny@...el.com" <ira.weiny@...el.com>,
	"david@...hat.com" <david@...hat.com>, "Vilas.Sridharan@....com"
	<Vilas.Sridharan@....com>, "leo.duran@....com" <leo.duran@....com>,
	"Yazen.Ghannam@....com" <Yazen.Ghannam@....com>, "rientjes@...gle.com"
	<rientjes@...gle.com>, "jiaqiyan@...gle.com" <jiaqiyan@...gle.com>,
	"Jon.Grimm@....com" <Jon.Grimm@....com>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "naoya.horiguchi@....com"
	<naoya.horiguchi@....com>, "james.morse@....com" <james.morse@....com>,
	"jthoughton@...gle.com" <jthoughton@...gle.com>, "somasundaram.a@....com"
	<somasundaram.a@....com>, "erdemaktas@...gle.com" <erdemaktas@...gle.com>,
	"pgonda@...gle.com" <pgonda@...gle.com>, "duenwen@...gle.com"
	<duenwen@...gle.com>, "gthelen@...gle.com" <gthelen@...gle.com>,
	"wschwartz@...erecomputing.com" <wschwartz@...erecomputing.com>,
	"dferguson@...erecomputing.com" <dferguson@...erecomputing.com>,
	"wbs@...amperecomputing.com" <wbs@...amperecomputing.com>,
	"nifan.cxl@...il.com" <nifan.cxl@...il.com>, tanxiaofei
	<tanxiaofei@...wei.com>, "Zengtao (B)" <prime.zeng@...ilicon.com>, "Roberto
 Sassu" <roberto.sassu@...wei.com>, "kangkang.shen@...urewei.com"
	<kangkang.shen@...urewei.com>, wanghuiqiang <wanghuiqiang@...wei.com>,
	Linuxarm <linuxarm@...wei.com>
Subject: RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for
 kernel usage

>-----Original Message-----
>From: Shiju Jose <shiju.jose@...wei.com>
>Sent: 09 December 2024 14:28
>To: Dan Williams <dan.j.williams@...el.com>; linux-edac@...r.kernel.org;
>linux-cxl@...r.kernel.org; linux-acpi@...r.kernel.org; linux-mm@...ck.org;
>linux-kernel@...r.kernel.org
>Cc: bp@...en8.de; tony.luck@...el.com; rafael@...nel.org; lenb@...nel.org;
>mchehab@...nel.org; dave@...olabs.net; Jonathan Cameron
><jonathan.cameron@...wei.com>; dave.jiang@...el.com;
>alison.schofield@...el.com; vishal.l.verma@...el.com; ira.weiny@...el.com;
>david@...hat.com; Vilas.Sridharan@....com; leo.duran@....com;
>Yazen.Ghannam@....com; rientjes@...gle.com; jiaqiyan@...gle.com;
>Jon.Grimm@....com; dave.hansen@...ux.intel.com;
>naoya.horiguchi@....com; james.morse@....com; jthoughton@...gle.com;
>somasundaram.a@....com; erdemaktas@...gle.com; pgonda@...gle.com;
>duenwen@...gle.com; gthelen@...gle.com;
>wschwartz@...erecomputing.com; dferguson@...erecomputing.com;
>wbs@...amperecomputing.com; nifan.cxl@...il.com; tanxiaofei
><tanxiaofei@...wei.com>; Zengtao (B) <prime.zeng@...ilicon.com>; Roberto
>Sassu <roberto.sassu@...wei.com>; kangkang.shen@...urewei.com;
>wanghuiqiang <wanghuiqiang@...wei.com>; Linuxarm
><linuxarm@...wei.com>
>Subject: RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for
>kernel usage
>
>>-----Original Message-----
>>From: Dan Williams <dan.j.williams@...el.com>
>>Sent: 06 December 2024 21:41
>>To: Shiju Jose <shiju.jose@...wei.com>; linux-edac@...r.kernel.org;
>>linux- cxl@...r.kernel.org; linux-acpi@...r.kernel.org;
>>linux-mm@...ck.org; linux- kernel@...r.kernel.org
>>Cc: bp@...en8.de; tony.luck@...el.com; rafael@...nel.org;
>>lenb@...nel.org; mchehab@...nel.org; dan.j.williams@...el.com;
>>dave@...olabs.net; Jonathan Cameron <jonathan.cameron@...wei.com>;
>>dave.jiang@...el.com; alison.schofield@...el.com;
>>vishal.l.verma@...el.com; ira.weiny@...el.com; david@...hat.com;
>>Vilas.Sridharan@....com; leo.duran@....com; Yazen.Ghannam@....com;
>>rientjes@...gle.com; jiaqiyan@...gle.com; Jon.Grimm@....com;
>>dave.hansen@...ux.intel.com; naoya.horiguchi@....com;
>>james.morse@....com; jthoughton@...gle.com;
>somasundaram.a@....com;
>>erdemaktas@...gle.com; pgonda@...gle.com; duenwen@...gle.com;
>>gthelen@...gle.com; wschwartz@...erecomputing.com;
>>dferguson@...erecomputing.com; wbs@...amperecomputing.com;
>>nifan.cxl@...il.com; tanxiaofei <tanxiaofei@...wei.com>; Zengtao (B)
>><prime.zeng@...ilicon.com>; Roberto Sassu <roberto.sassu@...wei.com>;
>>kangkang.shen@...urewei.com; wanghuiqiang <wanghuiqiang@...wei.com>;
>>Linuxarm <linuxarm@...wei.com>; Shiju Jose <shiju.jose@...wei.com>
>>Subject: Re: [PATCH v17 05/18] cxl: Add Get Supported Features command
>>for kernel usage
>>
>>shiju.jose@ wrote:
>>> From: Dave Jiang <dave.jiang@...el.com>
>>>
>>> CXL spec r3.1 8.2.9.6.1 Get Supported Features (Opcode 0500h) The
>>> command retrieve the list of supported device-specific features
>>> (identified by UUID) and general information about each Feature.
>>>
>>> The driver will retrieve the feature entries in order to make checks
>>> and provide information for the Get Feature and Set Feature command.
>>> One of the main piece of information retrieved are the effects a Set
>>> Feature command would have for a particular feature.
>>>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>>> Signed-off-by: Dave Jiang <dave.jiang@...el.com>
>>> Co-developed-by: Shiju Jose <shiju.jose@...wei.com>
>>> Signed-off-by: Shiju Jose <shiju.jose@...wei.com>
>>> ---
>>>  drivers/cxl/core/mbox.c      | 179 +++++++++++++++++++++++++++++++++++
>>>  drivers/cxl/cxlmem.h         |  44 +++++++++
>>>  drivers/cxl/pci.c            |   4 +
>>>  include/cxl/mailbox.h        |   4 +
>>>  include/uapi/linux/cxl_mem.h |   1 +
>>>  5 files changed, 232 insertions(+)
>>
>>Hi Shiju,
>>
>>So I commented yesterday on this patch that is also duplicated in
>>Dave's series have a merge order ordering plan to propose.
>
>Hi Dan,
>
>Thanks for the suggestions.
>I tested your suggestions for CXL features commands in the fwctl series, in the
>EDAC CXL features setup, as replied.

Please find updated patches for your suggestions are shared here.
https://github.com/shijujose4/linux/tree/edac-enhancement-ras-features_for_v18

However next version (v18) of EDAC series will send after receiving feedbacks from Borislav 
on v17 EDAC patches.

>>
>>> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index
[...]
>

Thanks,
Shiju