linux-kernel - Re: [PATCH net-next v3] nfp: Convert timeouts to secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58c2bbb7-cf39-4832-9e31-60ed9302372a@linux.microsoft.com>
Date: Wed, 11 Dec 2024 10:10:13 -0800
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Louis Peens <louis.peens@...igine.com>
Cc: eahariha@...ux.microsoft.com, Jakub Kicinski <kuba@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Jinjie Ruan <ruanjinjie@...wei.com>,
 James Hershaw <james.hershaw@...igine.com>,
 Johannes Berg <johannes.berg@...el.com>, Mohammad Heib <mheib@...hat.com>,
 Fei Qin <fei.qin@...igine.com>,
 "open list:NETRONOME ETHERNET DRIVERS" <oss-drivers@...igine.com>,
 "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3] nfp: Convert timeouts to secs_to_jiffies()

On 12/11/2024 1:39 AM, Louis Peens wrote:
> On Tue, Dec 10, 2024 at 10:56:53PM +0000, Easwar Hariharan wrote:
>> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
>> secs_to_jiffies(). As the value here is a multiple of 1000, use
>> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
>>
>> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
>> the following Coccinelle rules:
>>
>> @@ constant C; @@
>>
>> - msecs_to_jiffies(C * 1000)
>> + secs_to_jiffies(C)
>>
>> @@ constant C; @@
>>
>> - msecs_to_jiffies(C * MSEC_PER_SEC)
>> + secs_to_jiffies(C)
>>
>> Signed-off-by: Easwar Hariharan <eahariha@...ux.microsoft.com>
>> ---
>> This patch is pulled out from v2 [1] of my series to convert users of
>> msecs_to_jiffies() that need seconds-denominated timeouts to the new
>> secs_to_jiffies() API in include/linux/jiffies.h to send with the
>> net-next prefix as suggested by Christophe Leroy.
>>
>> It may be possible to use prefixes for some patches but not others with b4
>> (that I'm using to manage the series as a whole) but I didn't find such
>> in the help. v3 of the series addressing other review comments is here:
>> https://lore.kernel.org/r/20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com
>>
>> [1]: https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com
>> ---

<snip>

>> -- 
>> 2.43.0
>>
> It's not super clear to me which patch is handled where and through which tree
> at the moment, but looks like this is a network driver change scoped to the
> netdev tree, so makes sense to me to add sign-off here. Thanks for applying
> this to the nfp driver.
> 
> Reviewed-by: Louis Peens <louis.peens@...igine.com>

Thanks for the review! All netdev patches will be handled via the netdev
tree, separately from the series, per Jakub's request. There are patches
for gve and ath11k that will also be pulled out from the series and go
through netdev. I'll send a v4 series to netdev including your
Reviewed-by for this patch.

Thanks,
Easwar