linux-kernel - Re: [PATCH net-next v1 04/11] net: usb: lan78xx: Add error handling to lan78xx_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241210185335.7568ce45@kernel.org>
Date: Tue, 10 Dec 2024 18:53:35 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Woojung Huh
 <woojung.huh@...rochip.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com, Phil Elwell
 <phil@...pberrypi.org>
Subject: Re: [PATCH net-next v1 04/11] net: usb: lan78xx: Add error handling
 to lan78xx_get_regs

On Mon,  9 Dec 2024 14:07:44 +0100 Oleksij Rempel wrote:
> Update `lan78xx_get_regs` to handle errors during register and PHY
> reads.  Log warnings for failed reads and exit the function early if an
> error occurs.  This ensures that invalid data is not returned to users.

Should we zero out all the returned regs, too? 
Make it more obvious we failed.