| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <8ac2498e8056c275d969753b1b4947fc6816595d.camel@intel.com>
Date: Wed, 11 Dec 2024 20:01:11 +0000
From: "Colberg, Peter" <peter.colberg@...el.com>
To: "yilun.xu@...ux.intel.com" <yilun.xu@...ux.intel.com>
CC: "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
"matthew.gerlach@...ux.intel.com" <matthew.gerlach@...ux.intel.com>,
"basheer.ahmed.muddebihal@...ux.intel.com"
<basheer.ahmed.muddebihal@...ux.intel.com>
Subject: Re: [linux-next:master 2638/3192] drivers/fpga/dfl.c:817:47: sparse:
sparse: incorrect type in return expression (different address spaces)
Hi Yilun,
On Wed, 2024-12-11 at 20:32 +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 91e71d606356e50f238d7a87aacdee4abc427f07
> commit: d616a38d377f7204ebb905ef9b475870e02013c4 [2638/3192] fpga: dfl: factor out feature device data from platform device data
> config: i386-randconfig-062-20241211 (https://download.01.org/0day-ci/archive/20241211/202412112004.h3MCo8xA-lkp@intel.com/config)
> compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241211/202412112004.h3MCo8xA-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202412112004.h3MCo8xA-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> > > drivers/fpga/dfl.c:817:47: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected struct dfl_feature_dev_data * @@ got void [noderef] __iomem *ioaddr @@
> drivers/fpga/dfl.c:817:47: sparse: expected struct dfl_feature_dev_data *
> drivers/fpga/dfl.c:817:47: sparse: got void [noderef] __iomem *ioaddr
> drivers/fpga/dfl.c: note: in included file (through include/linux/smp.h, include/linux/lockdep.h, include/linux/spinlock.h, ...):
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
>
> vim +817 drivers/fpga/dfl.c
>
> 543be3d8c999b3 Wu Hao 2018-06-30 742
> a25cd37037c853 Peter Colberg 2024-11-19 743 static struct dfl_feature_dev_data *
> dbd805600eb35d Peter Colberg 2024-11-19 744 binfo_create_feature_dev_data(struct build_feature_devs_info *binfo)
> 543be3d8c999b3 Wu Hao 2018-06-30 745 {
> 543be3d8c999b3 Wu Hao 2018-06-30 746 struct platform_device *fdev = binfo->feature_dev;
> 98ae80101081b0 Peter Colberg 2024-11-19 747 enum dfl_id_type type = binfo->type;
> 543be3d8c999b3 Wu Hao 2018-06-30 748 struct dfl_feature_info *finfo, *p;
> a25cd37037c853 Peter Colberg 2024-11-19 749 struct dfl_feature_dev_data *fdata;
> dbd805600eb35d Peter Colberg 2024-11-19 750 int index = 0, res_idx = 0;
> 543be3d8c999b3 Wu Hao 2018-06-30 751
> dfe3de8d397bf8 Scott Wood 2019-05-09 752 if (WARN_ON_ONCE(type >= DFL_ID_MAX))
> dbd805600eb35d Peter Colberg 2024-11-19 753 return ERR_PTR(-EINVAL);
> dfe3de8d397bf8 Scott Wood 2019-05-09 754
> d616a38d377f72 Peter Colberg 2024-11-19 755 fdata = devm_kzalloc(binfo->dev, struct_size(fdata, features, binfo->feature_num), GFP_KERNEL);
> a25cd37037c853 Peter Colberg 2024-11-19 756 if (!fdata)
> dbd805600eb35d Peter Colberg 2024-11-19 757 return ERR_PTR(-ENOMEM);
> 543be3d8c999b3 Wu Hao 2018-06-30 758
> a25cd37037c853 Peter Colberg 2024-11-19 759 fdata->dev = fdev;
> a25cd37037c853 Peter Colberg 2024-11-19 760 fdata->type = type;
> a25cd37037c853 Peter Colberg 2024-11-19 761 fdata->num = binfo->feature_num;
> a25cd37037c853 Peter Colberg 2024-11-19 762 fdata->dfl_cdev = binfo->cdev;
> a25cd37037c853 Peter Colberg 2024-11-19 763 fdata->id = FEATURE_DEV_ID_UNUSED;
> a25cd37037c853 Peter Colberg 2024-11-19 764 mutex_init(&fdata->lock);
> a25cd37037c853 Peter Colberg 2024-11-19 765 lockdep_set_class_and_name(&fdata->lock, &dfl_pdata_keys[type],
> dfe3de8d397bf8 Scott Wood 2019-05-09 766 dfl_pdata_key_strings[type]);
> 543be3d8c999b3 Wu Hao 2018-06-30 767
> 543be3d8c999b3 Wu Hao 2018-06-30 768 /*
> 543be3d8c999b3 Wu Hao 2018-06-30 769 * the count should be initialized to 0 to make sure
> 543be3d8c999b3 Wu Hao 2018-06-30 770 *__fpga_port_enable() following __fpga_port_disable()
> 543be3d8c999b3 Wu Hao 2018-06-30 771 * works properly for port device.
> 543be3d8c999b3 Wu Hao 2018-06-30 772 * and it should always be 0 for fme device.
> 543be3d8c999b3 Wu Hao 2018-06-30 773 */
> a25cd37037c853 Peter Colberg 2024-11-19 774 WARN_ON(fdata->disable_count);
> 543be3d8c999b3 Wu Hao 2018-06-30 775
> 543be3d8c999b3 Wu Hao 2018-06-30 776 /* each sub feature has one MMIO resource */
> 543be3d8c999b3 Wu Hao 2018-06-30 777 fdev->num_resources = binfo->feature_num;
> 543be3d8c999b3 Wu Hao 2018-06-30 778 fdev->resource = kcalloc(binfo->feature_num, sizeof(*fdev->resource),
> 543be3d8c999b3 Wu Hao 2018-06-30 779 GFP_KERNEL);
> 543be3d8c999b3 Wu Hao 2018-06-30 780 if (!fdev->resource)
> dbd805600eb35d Peter Colberg 2024-11-19 781 return ERR_PTR(-ENOMEM);
> 543be3d8c999b3 Wu Hao 2018-06-30 782
> 543be3d8c999b3 Wu Hao 2018-06-30 783 /* fill features and resource information for feature dev */
> 543be3d8c999b3 Wu Hao 2018-06-30 784 list_for_each_entry_safe(finfo, p, &binfo->sub_features, node) {
> a25cd37037c853 Peter Colberg 2024-11-19 785 struct dfl_feature *feature = &fdata->features[index++];
> 8d021039cbb5e3 Xu Yilun 2020-06-16 786 struct dfl_feature_irq_ctx *ctx;
> 8d021039cbb5e3 Xu Yilun 2020-06-16 787 unsigned int i;
> 543be3d8c999b3 Wu Hao 2018-06-30 788
> 543be3d8c999b3 Wu Hao 2018-06-30 789 /* save resource information for each feature */
> 322b598be4d9b9 Xu Yilun 2020-06-16 790 feature->dev = fdev;
> 543be3d8c999b3 Wu Hao 2018-06-30 791 feature->id = finfo->fid;
> 1604986c3e6bd8 Martin Hundebøll 2021-07-16 792 feature->revision = finfo->revision;
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 793 feature->dfh_version = finfo->dfh_version;
> 89eb35e810a87d Xu Yilun 2020-08-19 794
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 795 if (finfo->param_size) {
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 796 feature->params = devm_kmemdup(binfo->dev,
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 797 finfo->params, finfo->param_size,
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 798 GFP_KERNEL);
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 799 if (!feature->params)
> dbd805600eb35d Peter Colberg 2024-11-19 800 return ERR_PTR(-ENOMEM);
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 801
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 802 feature->param_size = finfo->param_size;
> 4747ab89b4a652 Matthew Gerlach 2023-01-15 803 }
> 89eb35e810a87d Xu Yilun 2020-08-19 804 /*
> 89eb35e810a87d Xu Yilun 2020-08-19 805 * the FIU header feature has some fundamental functions (sriov
> 89eb35e810a87d Xu Yilun 2020-08-19 806 * set, port enable/disable) needed for the dfl bus device and
> 89eb35e810a87d Xu Yilun 2020-08-19 807 * other sub features. So its mmio resource should be mapped by
> 89eb35e810a87d Xu Yilun 2020-08-19 808 * DFL bus device. And we should not assign it to feature
> 89eb35e810a87d Xu Yilun 2020-08-19 809 * devices (dfl-fme/afu) again.
> 89eb35e810a87d Xu Yilun 2020-08-19 810 */
> 89eb35e810a87d Xu Yilun 2020-08-19 811 if (is_header_feature(feature)) {
> 89eb35e810a87d Xu Yilun 2020-08-19 812 feature->resource_index = -1;
> 89eb35e810a87d Xu Yilun 2020-08-19 813 feature->ioaddr =
> 89eb35e810a87d Xu Yilun 2020-08-19 814 devm_ioremap_resource(binfo->dev,
> 89eb35e810a87d Xu Yilun 2020-08-19 815 &finfo->mmio_res);
> 89eb35e810a87d Xu Yilun 2020-08-19 816 if (IS_ERR(feature->ioaddr))
> dbd805600eb35d Peter Colberg 2024-11-19 @817 return feature->ioaddr;
Would you be open to amending commit dbd805600eb3 ("fpga: dfl: factor
out feature data creation from build_info_commit_dev()") as follows?
--- a/drivers/fpga/dfl.c
+++ b/drivers/fpga/dfl.c
@@ -828,7 +828,7 @@ binfo_create_feature_dev_data(struct build_feature_devs_info *binfo)
devm_ioremap_resource(binfo->dev,
&finfo->mmio_res);
if (IS_ERR(feature->ioaddr))
- return feature->ioaddr;
+ return ERR_CAST(feature->ioaddr);
} else {
feature->resource_index = res_idx;
fdata->resources[res_idx++] = finfo->mmio_res;
https://patchwork.kernel.org/project/linux-fpga/patch/20240919203430.1278067-7-peter.colberg@intel.com/#26036951
Thanks,
Peter
> 89eb35e810a87d Xu Yilun 2020-08-19 818 } else {
> 89eb35e810a87d Xu Yilun 2020-08-19 819 feature->resource_index = res_idx;
> 89eb35e810a87d Xu Yilun 2020-08-19 820 fdev->resource[res_idx++] = finfo->mmio_res;
> 89eb35e810a87d Xu Yilun 2020-08-19 821 }
> 543be3d8c999b3 Wu Hao 2018-06-30 822
> 8d021039cbb5e3 Xu Yilun 2020-06-16 823 if (finfo->nr_irqs) {
> 8d021039cbb5e3 Xu Yilun 2020-06-16 824 ctx = devm_kcalloc(binfo->dev, finfo->nr_irqs,
> 8d021039cbb5e3 Xu Yilun 2020-06-16 825 sizeof(*ctx), GFP_KERNEL);
> 8d021039cbb5e3 Xu Yilun 2020-06-16 826 if (!ctx)
> dbd805600eb35d Peter Colberg 2024-11-19 827 return ERR_PTR(-ENOMEM);
> 8d021039cbb5e3 Xu Yilun 2020-06-16 828
> 8d021039cbb5e3 Xu Yilun 2020-06-16 829 for (i = 0; i < finfo->nr_irqs; i++)
> 8d021039cbb5e3 Xu Yilun 2020-06-16 830 ctx[i].irq =
> 8d021039cbb5e3 Xu Yilun 2020-06-16 831 binfo->irq_table[finfo->irq_base + i];
> 8d021039cbb5e3 Xu Yilun 2020-06-16 832
> 8d021039cbb5e3 Xu Yilun 2020-06-16 833 feature->irq_ctx = ctx;
> 8d021039cbb5e3 Xu Yilun 2020-06-16 834 feature->nr_irqs = finfo->nr_irqs;
> 8d021039cbb5e3 Xu Yilun 2020-06-16 835 }
> 8d021039cbb5e3 Xu Yilun 2020-06-16 836
> 543be3d8c999b3 Wu Hao 2018-06-30 837 list_del(&finfo->node);
> 543be3d8c999b3 Wu Hao 2018-06-30 838 kfree(finfo);
> 543be3d8c999b3 Wu Hao 2018-06-30 839 }
> 543be3d8c999b3 Wu Hao 2018-06-30 840
> a25cd37037c853 Peter Colberg 2024-11-19 841 return fdata;
> 543be3d8c999b3 Wu Hao 2018-06-30 842 }
> 543be3d8c999b3 Wu Hao 2018-06-30 843
>
> :::::: The code at line 817 was first introduced by commit
> :::::: dbd805600eb35d1000bbc3566cfc7c35d9c67e3e fpga: dfl: factor out feature data creation from build_info_commit_dev()
>
> :::::: TO: Peter Colberg <peter.colberg@...el.com>
> :::::: CC: Xu Yilun <yilun.xu@...ux.intel.com>
>
Powered by blists - more mailing lists