linux-kernel - Re: [PATCH v2 05/14] drm/msm/dp: move I/O functions to global header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n53hKPr2WsGWTy24qfsSO4TbmtnY5bOQQ51UuW4RPUz0Dg@mail.gmail.com>
Date: Wed, 11 Dec 2024 13:09:21 -0800
From: Stephen Boyd <swboyd@...omium.org>
To: Abhinav Kumar <quic_abhinavk@...cinc.com>, David Airlie <airlied@...il.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, Paloma Arellano <quic_parellan@...cinc.com>, 
	Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>, Simona Vetter <simona@...ll.ch>
Cc: Douglas Anderson <dianders@...omium.org>, linux-arm-msm@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/14] drm/msm/dp: move I/O functions to global header

Quoting Dmitry Baryshkov (2024-12-02 02:06:35)
> diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.h b/drivers/gpu/drm/msm/dp/dp_catalog.h
> index 13486c9c8703748e69e846be681951368df0a29e..2c500dc0898edfe1d6bdac2eedf3c1b78056cf6b 100644
> --- a/drivers/gpu/drm/msm/dp/dp_catalog.h
> +++ b/drivers/gpu/drm/msm/dp/dp_catalog.h
[...]
> +
> +static inline u32 msm_dp_read_p0(struct msm_dp_catalog *msm_dp_catalog,
> +                              u32 offset)
> +{
> +       /*
> +        * To make sure interface reg writes happens before any other operation,
> +        * this function uses writel() instread of writel_relaxed()

It's readl_relaxed() below.

> +        */
> +       return readl_relaxed(msm_dp_catalog->p0_base + offset);
> +}