linux-kernel - Re: [PATCH v6 3/3] riscv: dts: thead: Add mailbox node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1oO5ewIOMFco4KI@x1>
Date: Wed, 11 Dec 2024 14:15:01 -0800
From: Drew Fustini <dfustini@...storrent.com>
To: Michal Wilczynski <m.wilczynski@...sung.com>
Cc: drew@...7.com, guoren@...nel.org, wefu@...hat.com,
	jassisinghbrar@...il.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, paul.walmsley@...ive.com, palmer@...belt.com,
	aou@...s.berkeley.edu, m.szyprowski@...sung.com,
	samuel.holland@...ive.com, emil.renner.berthing@...onical.com,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, christophe.jaillet@...adoo.fr
Subject: Re: [PATCH v6 3/3] riscv: dts: thead: Add mailbox node

On Mon, Nov 04, 2024 at 11:07:34AM +0100, Michal Wilczynski wrote:
> Add mailbox device tree node. This work is based on the vendor kernel [1].
> 
> Link: https://github.com/revyos/thead-kernel.git [1]
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@...sung.com>
> ---
>  arch/riscv/boot/dts/thead/th1520.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index 6992060e6a54..89de5634d3d3 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -520,6 +520,22 @@ timer7: timer@...fc3303c {
>  			status = "disabled";
>  		};
>  
> +		mbox_910t: mailbox@...fc38000 {
> +			compatible = "thead,th1520-mbox";
> +			reg = <0xff 0xffc38000 0x0 0x6000>,
> +			      <0xff 0xffc40000 0x0 0x6000>,
> +			      <0xff 0xffc4c000 0x0 0x2000>,
> +			      <0xff 0xffc54000 0x0 0x2000>;
> +			reg-names = "local", "remote-icu0", "remote-icu1", "remote-icu2";
> +			clocks = <&clk CLK_MBOX0>, <&clk CLK_MBOX1>, <&clk CLK_MBOX2>,
> +				 <&clk CLK_MBOX3>;
> +			clock-names = "clk-local", "clk-remote-icu0", "clk-remote-icu1",
> +				      "clk-remote-icu2";
> +			interrupt-parent = <&plic>;
> +			interrupts = <28 IRQ_TYPE_LEVEL_HIGH>;
> +			#mbox-cells = <1>;
> +		};
> +
>  		ao_gpio0: gpio@...ff41000 {
>  			compatible = "snps,dw-apb-gpio";
>  			reg = <0xff 0xfff41000 0x0 0x1000>;
> -- 
> 2.34.1
> 

Reviewed-by: Drew Fustini <dfustini@...storrent.com>

dt_binding_check and dtbs_check are clean when I apply this patch to
v6.13-rc1. There is trivial conflict due to the gpio node label having
changed. I'll resolve it when I apply the patch to thead-dt-for-next.

Thanks,
Drew