linux-kernel - Re: [PATCH v5 05/10] objtool/LoongArch: Add support for switch table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8747e7fb-f2e5-f3d1-c3c4-1fdd05120bda@loongson.cn>
Date: Wed, 11 Dec 2024 11:18:10 +0800
From: Tiezhu Yang <yangtiezhu@...ngson.cn>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: Huacai Chen <chenhuacai@...nel.org>, Peter Zijlstra
 <peterz@...radead.org>, loongarch@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 05/10] objtool/LoongArch: Add support for switch table

On 12/10/2024 04:39 AM, Josh Poimboeuf wrote:
> On Sat, Dec 07, 2024 at 09:59:10AM +0800, Tiezhu Yang wrote:
>>  struct reloc *arch_find_switch_table(struct objtool_file *file,
>>  				     struct instruction *insn,
>>  				     unsigned long *table_size)
>>  {
>
> This seems to be a partial implementation as it doesn't set
> 'table_size', resulting in undefined behavior when the size gets used by
> objtool later.   I suppose this patch should be squashed with the next
> one?

OK, makes sense, I will squash them into one single patch.

Let me wait for some days, if no more comments, I will send v6
in the next week.

Thanks,
Tiezhu