linux-kernel - Re: [PATCH v8 27/28] media: iris: enable video driver probe of SM8250 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4f35301-6361-9e07-73dc-023e87c80857@quicinc.com>
Date: Wed, 11 Dec 2024 11:54:09 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Stefan Schmidt <stefan.schmidt@...aro.org>
CC: Vikash Garodia <quic_vgarodia@...cinc.com>,
        Abhinav Kumar
	<quic_abhinavk@...cinc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Hans
 Verkuil" <hverkuil@...all.nl>,
        Sebastian Fricke
	<sebastian.fricke@...labora.com>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Nicolas Dufresne
	<nicolas@...fresne.ca>,
        Uwe Kleine-König
	<u.kleine-koenig@...libre.com>,
        Jianhua Lu <lujianhua000@...il.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 27/28] media: iris: enable video driver probe of SM8250
 SoC



On 12/10/2024 9:53 PM, Stefan Schmidt wrote:
> hello Dikshita,
> 
> On Tue, 10 Dec 2024 at 12:08, Dikshita Agarwal
> <quic_dikshita@...cinc.com> wrote:
>>
>> Initialize the platform data and enable video driver probe of SM8250
>> SoC. Add a kernel param to select between venus and iris drivers for
>> platforms supported by both drivers, for ex: SM8250.
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@...cinc.com>
> 
> [...]
> 
>> --- a/drivers/media/platform/qcom/iris/iris_ctrls.c
>> +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c
>> @@ -17,6 +17,8 @@ static inline bool iris_valid_cap_id(enum platform_inst_fw_cap_type cap_id)
>>  static enum platform_inst_fw_cap_type iris_get_cap_id(u32 id)
>>  {
>>         switch (id) {
>> +       case V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER:
>> +               return DEBLOCK;
>>         case V4L2_CID_MPEG_VIDEO_H264_PROFILE:
>>                 return PROFILE;
>>         case V4L2_CID_MPEG_VIDEO_H264_LEVEL:
>> @@ -32,6 +34,8 @@ static u32 iris_get_v4l2_id(enum platform_inst_fw_cap_type cap_id)
>>                 return 0;
>>
>>         switch (cap_id) {
>> +       case DEBLOCK:
>> +               return V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER;
>>         case PROFILE:
> 
> The handling for DEBLOCK does not seem to be part of the SM8250
> enablement. Or did I miss something?
> It seems they should be part of a different patch that makes use of
> the DEBLOCK cap.
> 
this cap is part of platform caps of SM8250 and the value(set by
client/default) of this will set to firmware as part of start streaming
through set APIs.
{
+		.cap_id = DEBLOCK,
+		.min = 0,
+		.max = 1,
+		.step_or_mask = 1,
+		.value = 0,
+		.hfi_id = HFI_PROPERTY_CONFIG_VDEC_POST_LOOP_DEBLOCKER,
+		.set = iris_set_u32,
+	},

Thanks,
Dikshita
> regards
> Stefan Schmidt