linux-kernel - Re: [PATCH v13 01/25] virt: geniezone: enable gzvm-ko in defconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ecf2e8c-86cd-4ba2-832b-014a05a80d26@kernel.org>
Date: Wed, 11 Dec 2024 09:38:54 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Liju-clr Chen <liju-clr.chen@...iatek.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 Richard Cochran <richardcochran@...il.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Yingshiuan Pan <Yingshiuan.Pan@...iatek.com>,
 Ze-yu Wang <Ze-yu.Wang@...iatek.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, Shawn Hsiao <shawn.hsiao@...iatek.com>,
 PeiLun Suei <PeiLun.Suei@...iatek.com>,
 Chi-shen Yeh <Chi-shen.Yeh@...iatek.com>,
 Kevenny Hsieh <Kevenny.Hsieh@...iatek.com>
Subject: Re: [PATCH v13 01/25] virt: geniezone: enable gzvm-ko in defconfig

On 14/11/2024 11:07, Liju-clr Chen wrote:
> From: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> 

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.


> Add config in defconfig to enable gzvm driver by default

This we see from the diff. You must explain why we want it.

> 
> Signed-off-by: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> Signed-off-by: Yi-De Wu <yi-de.wu@...iatek.com>
> Signed-off-by: Liju Chen <liju-clr.chen@...iatek.com>
> ---
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index d13218d0c30f..0f63d4837b61 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1733,3 +1733,5 @@ CONFIG_CORESIGHT_STM=m
>  CONFIG_CORESIGHT_CPU_DEBUG=m
>  CONFIG_CORESIGHT_CTI=m
>  CONFIG_MEMTEST=y
> +CONFIG_VIRT_DRIVERS=y
> +CONFIG_MTK_GZVM=m

Does not look like placed correctly, according to savedefconfig.

I still do not see any reason to have it enabled.

Your patches have weird order or this is just wrong. There is no such
thing as "MTK_GZVM". Use git grep, if you do not believe me.


Best regards,
Krzysztof