linux-kernel - Re: [PATCH v5 2/5] pinctrl: mediatek: add MT7988 pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <598f595589d061bf314d942095cd5dc6@fw-web.de>
Date: Wed, 11 Dec 2024 09:43:58 +0100
From: "Frank Wunderlich (linux)" <linux@...web.de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Sean
 Wang <sean.wang@...nel.org>, Frank Wunderlich <frank-w@...lic-files.de>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, Daniel Golle <daniel@...rotopia.org>,
 Sam Shih <sam.shih@...iatek.com>, Arınç ÜNAL
 <arinc.unal@...nc9.com>
Subject: Re: [PATCH v5 2/5] pinctrl: mediatek: add MT7988 pinctrl driver

Am 2024-12-10 19:45, schrieb Christophe JAILLET:
> Le 02/12/2024 à 12:00, Frank Wunderlich a écrit :
>> From: Daniel Golle <daniel@...rotopia.org>
>> 
>> Add pinctrl driver for the MediaTek MT7988 SoC.
>> 
>> Signed-off-by: Sam Shih <sam.shih@...iatek.com>
>> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
>> [correctly initialise for the function_desc structure]
>> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
>> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
>> 
>> ---
> 
> ...
> 
>> +/* flash */
>> +static int mt7988_snfi_pins[] = { 22, 23, 24, 25, 26, 27 };
>> +static int mt7988_snfi_funcs[] = { 2, 2, 2, 2, 2, 2 };
>> +
>> +static int mt7988_emmc_45_pins[] = {
>> +	21, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37
>> +};
>> +static int mt7988_emmc_45_funcs[] = { 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5 
>> };
>> +
>> +static int mt7988_sdcard_pins[] = { 32, 33, 34, 35, 36, 37 };
>> +static int mt7988_sdcard_funcs[] = { 5, 5, 5, 5, 5, 5 };
>> +
>> +static int mt7988_emmc_51_pins[] = { 38, 39, 40, 41, 42, 43,
>> +				     44, 45, 46, 47, 48, 49 };
>> +static int mt7988_emmc_51_funcs[] = { 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 
>> 1, 1 };
> 
> At least all the _pins arrays could be const.
> Maybe we could also make it possible to have _funcs const as well.
> 
> ...
> 
>> +static struct mtk_pin_soc mt7988_data = {
> 
> const?

can do, but for funcs i see no clear way

angelo, can i keep the RB, when changing pins/mtk_pin_soc to const 
(without changing macro in drivers/pinctrl/mediatek/pinctrl-moore.h)?

>> +	.reg_cal = mt7988_reg_cals,
>> +	.pins = mt7988_pins,
>> +	.npins = ARRAY_SIZE(mt7988_pins),
>> +	.grps = mt7988_groups,
>> +	.ngrps = ARRAY_SIZE(mt7988_groups),
>> +	.funcs = mt7988_functions,
>> +	.nfuncs = ARRAY_SIZE(mt7988_functions),
>> +	.eint_hw = &mt7988_eint_hw,
>> +	.gpio_m = 0,
>> +	.ies_present = false,
>> +	.base_names = mt7988_pinctrl_register_base_names,
>> +	.nbase_names = ARRAY_SIZE(mt7988_pinctrl_register_base_names),
>> +	.bias_disable_set = mtk_pinconf_bias_disable_set,
>> +	.bias_disable_get = mtk_pinconf_bias_disable_get,
>> +	.bias_set = mtk_pinconf_bias_set,
>> +	.bias_get = mtk_pinconf_bias_get,
>> +	.pull_type = mt7988_pull_type,
>> +	.bias_set_combo = mtk_pinconf_bias_set_combo,
>> +	.bias_get_combo = mtk_pinconf_bias_get_combo,
>> +	.drive_set = mtk_pinconf_drive_set_rev1,
>> +	.drive_get = mtk_pinconf_drive_get_rev1,
>> +	.adv_pull_get = mtk_pinconf_adv_pull_get,
>> +	.adv_pull_set = mtk_pinconf_adv_pull_set,
>> +};
> 
> ...
> 
> CJ