[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <12942826.iMDcRRXYNz@diego>
Date: Wed, 11 Dec 2024 09:46:57 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Sandy Huang <hjc@...k-chips.com>, Andy Yan <andy.yan@...k-chips.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc: Alexandre ARNOUD <aarnoud@...com>, kernel@...labora.com,
dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v2 0/4] Add support for HDMI1 output on RK3588 SoC
Hi Cristian,
Am Mittwoch, 11. Dezember 2024, 00:06:13 CET schrieb Cristian Ciocaltea:
> The patches provide the basic support to handle the second HDMI output
> port found on Rockchip RK3588 SoC.
>
> For now I enabled it on Radxa ROCK 5B only, the board I've been using to
> validate this.
>
> ** IMPORTANT **
>
> The series has a runtime dependency on "phy: phy-rockchip-samsung-hdptx:
> Don't use dt aliases to determine phy-id", a patch submitted recently by
> Heiko [1]. Without applying it, the functionality on both HDMI TX ports
> will break.
Looking at the drm/rockchip patch, that should not cause disruptions on
its own, right?
Only with the dts-parts enabled would we run into phy-issue.
(Asking, because things go through different trees and the drm
part looks ready)
Heiko
> Furthermore, please note this is subject to the same limitations as
> HDMI0 when it comes to the supported display modes. The fixes provided
> via [2] are not applicable to HDMI1, hence I will handle it separately
> as soon as all dependencies are merged.
>
> Thanks,
> Cristian
>
> [1] https://lore.kernel.org/lkml/20241206103401.1780416-3-heiko@sntech.de/
> [2] https://lore.kernel.org/all/20241116-vop2-hdmi0-disp-modes-v1-0-2bca51db4898@collabora.com/
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> ---
> Changes in v2:
> - Override hdmi1 pinctrl-0 on rock-5b as it requires hdmim0_tx1_cec
> instead of hdmim2_tx1_cec (fixes a pin conflict when enabling
> CONFIG_SPI_ROCKCHIP_SFC)
> - Link to v1: https://lore.kernel.org/r/20241207-rk3588-hdmi1-v1-0-ca3a99b46a40@collabora.com
>
> ---
> Cristian Ciocaltea (4):
> drm/rockchip: dw_hdmi_qp: Add support for RK3588 HDMI1 output
> arm64: dts: rockchip: Add PHY node for HDMI1 TX port on RK3588
> arm64: dts: rockchip: Add HDMI1 node on RK3588
> arm64: dts: rockchip: Enable HDMI1 on rock-5b
>
> arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi | 62 ++++++++++++
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 44 ++++++++-
> drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 119 +++++++++++++++++++-----
> 3 files changed, 200 insertions(+), 25 deletions(-)
> ---
> base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
> change-id: 20241207-rk3588-hdmi1-704cbb7cd75f
>
>
Powered by blists - more mailing lists