linux-kernel - Re: [PATCH v4 07/13] wifi: ath12k: add support for fixed QMI firmware memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7qypvfjb34nyvcqmdw37zjpcxga5drvddwimlc3cuhejtyzjnz@4agqjdalxl7x>
Date: Wed, 11 Dec 2024 09:52:35 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>
Cc: ath12k@...ts.infradead.org, linux-wireless@...r.kernel.org, 
	Kalle Valo <kvalo@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jeff Johnson <jjohnson@...nel.org>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 07/13] wifi: ath12k: add support for fixed QMI
 firmware memory

On Tue, Dec 10, 2024 at 10:30:54PM +0530, Raj Kumar Bhagat wrote:
> On 12/10/2024 8:13 PM, Krzysztof Kozlowski wrote:
> > On 10/12/2024 08:41, Raj Kumar Bhagat wrote:
> >> +		case CALDB_MEM_REGION_TYPE:
> >> +			/* Cold boot calibration is not enabled in Ath12k. Hence,
> >> +			 * assign paddr = 0.
> >> +			 * Once cold boot calibration is enabled add support to
> >> +			 * assign reserved memory from DT.
> >> +			 */
> >> +			ab->qmi.target_mem[idx].paddr = 0;
> >> +			ab->qmi.target_mem[idx].v.ioaddr = NULL;
> >> +			ab->qmi.target_mem[idx].size = ab->qmi.target_mem[i].size;
> >> +			ab->qmi.target_mem[idx].type = ab->qmi.target_mem[i].type;
> >> +			idx++;
> >> +			break;
> >> +		case M3_DUMP_REGION_TYPE:
> >> +			dev_node = of_find_node_by_name(NULL, "m3_dump");
> > 
> > NAK
> > 
> > That's neither correct name nor documented in the bindings. You created
> > now undocumented ABI. Even with incorrect name. :/
> > 
> 
> Most of the Device Tree related concern in this series are from the
> undocumented ABIs and wrong naming (use of '_' instead of '-'):
> "m3_dump" and "mlo_global_mem_0".
> 
> To address the undocumented ABIs, "memory-region" and "memory-region-names"
> should be used to reference all the reserved memory required. This should
> include "m3_dump" and "mlo_global_mem_0" memory region.

You already use them, so this code here and explanation is confusing.

> 
> If the above approach valid to address undocumented ABIs?

Dunno. Change all node names, run dtbs_check. Do you see errors? Now run
your driver. Does it work correctly? If yes, then ABI seems documented.
If not, ABI is not documented.

Best regards,
Krzysztof