linux-kernel - Re: [PATCH v2 1/1] power: supply: gpio-charger: Support to disable charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4tvn5k6zbsbyc2n3r2jnkrasyfhzfua4cap6ql65yjfmwzu3xw@lx6jmqvzypqv>
Date: Wed, 11 Dec 2024 10:30:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stefan Raufhake <raufhakestefan@...il.com>
Cc: Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, s.raufhake@...khoff.com, 
	s.dirkwinkel@...khoff.com, Stefan Raufhake <s.raufhake@...khoff.de>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v2 1/1] power: supply: gpio-charger: Support to disable
 charger

On Tue, Dec 10, 2024 at 09:23:43AM +0000, Stefan Raufhake wrote:
> From: Stefan Raufhake <s.raufhake@...khoff.de>
> 
> Some GPIO-controlled power supplies can be turned off (charging disabled).
> Support changing the charging state by setting charge_type to
> POWER_SUPPLY_CHARGE_TYPE_STANDARD and disabling charging by setting
> charge_type to POWER_SUPPLY_CHARGE_TYPE_NONE. One potential use case for
> this is disabling battery backup on a UPS.
> 
> Signed-off-by: Stefan Raufhake <s.raufhake@...khoff.de>
> ---
>  .../bindings/power/supply/gpio-charger.yaml   |  6 +++
>  drivers/power/supply/gpio-charger.c           | 43 +++++++++++++++++++
>  2 files changed, 49 insertions(+)
> 

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>

> diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> index 89f8e2bcb2d7..084520bfc040 100644
> --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.yaml
> @@ -44,6 +44,10 @@ properties:
>      maxItems: 32
>      description: GPIOs used for current limiting
>  
> +  enable-gpios:
> +    maxItems: 1
> +    description: GPIO is used to enable/disable the charger
> +

You did not respond to my comments, nothing improved. Without
explanation based on hardware - which I asked - this is still a no.

Implement and respond fully to previous feedback.

Best regards,
Krzysztof