linux-kernel - Re: [PATCH 5/6] zram: factor out ZRAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241211100638.GA2228457@google.com>
Date: Wed, 11 Dec 2024 19:06:38 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Minchan Kim <minchan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] zram: factor out ZRAM_HUGE write

[..]On (24/12/10 19:53), Sergey Senozhatsky wrote:
> -				GFP_NOIO | __GFP_HIGHMEM |
> -				__GFP_MOVABLE);
> +				   GFP_NOIO | __GFP_HIGHMEM | __GFP_MOVABLE);
>  		if (IS_ERR_VALUE(handle))
>  			return PTR_ERR((void *)handle);
>  
> -		if (comp_len != PAGE_SIZE) {
> -			last_comp_len = comp_len;
> -			goto compress_again;
> -		}

I deleted too much, we need `last_comp_len = comp_len`.  This is why
I think zram_write_page() is too complex now.  (I'm still very very
unsre about last_comp_len patch.)


Andrew, please drop this whole series. I'll resend the combined
series (including zram writeback cond_resched() patch).