linux-kernel - Re: [PATCH v4 1/4] dt-bindings: net: bluetooth: qca: Expand firmware-name property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65fd0932-4519-44ac-ba9d-55ee97b43233@quicinc.com>
Date: Wed, 11 Dec 2024 18:16:44 +0800
From: "Cheng Jiang (IOE)" <quic_chejiang@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Marcel Holtmann <marcel@...tmann.org>,
        Luiz Augusto von Dentz
	<luiz.dentz@...il.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        "Balakrishna
 Godavarthi" <quic_bgodavar@...cinc.com>,
        Rocky Liao
	<quic_rjliao@...cinc.com>,
        <linux-bluetooth@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <quic_jiaymao@...cinc.com>, <quic_shuaz@...cinc.com>,
        <quic_zijuhu@...cinc.com>, <quic_mohamull@...cinc.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: net: bluetooth: qca: Expand
 firmware-name property

Hi Krzysztof,

On 12/11/2024 5:48 PM, Krzysztof Kozlowski wrote:
> On 11/12/2024 10:39, Cheng Jiang (IOE) wrote:
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> index 7bb68311c..2782d2325 100644
>>>> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
>>>> @@ -101,7 +101,10 @@ properties:
>>>>    max-speed: true
>>>>  
>>>>    firmware-name:
>>>> -    description: specify the name of nvm firmware to load
>>>> +    description:
>>>> +      If one item is present, specify the name of the NVM firmware to load.
>>>> +      If two items are present, the first item specifies the name of the NVM,
>>>> +      and the second specifies the name of the rampatch firmware to load.
>>>
>>> Don't repeat constraints in free form text. Use proper constraints so
>>> you can validate your DTS. And then actually do validate your DTS...
>>>
>> It seems unnecessary to add this description, so I will drop this change. Is that okay?
> 
> You need to list the items and describe them. See how all other bindings
> do it.
> 
The firmware names are not fixed strings; they vary depending on the chip, board, or platform.

How about the following description? Thank you!

  firmware-name:
    $ref: /schemas/types.yaml#/definitions/string
    description: |
      List of firmware names. The first item is the name of the NVM firmware
      to load. The second item is the name of the rampatch firmware to load,
      if present.
    minItems: 1
    maxItems: 2

> Best regards,
> Krzysztof