linux-kernel - Re: [PATCH v5 0/2] coresight: Add label sysfs node support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7bdaa38a-c114-4538-8fbb-85e0f326f436@quicinc.com>
Date: Wed, 11 Dec 2024 19:13:58 +0800
From: Jinlong Mao <quic_jinlmao@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Suzuki K Poulose <suzuki.poulose@....com>,
        Mike Leach
	<mike.leach@...aro.org>, James Clark <james.clark@....com>,
        Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Bjorn
 Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, <coresight@...ts.linaro.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v5 0/2] coresight: Add label sysfs node support



On 2024/12/11 16:46, Krzysztof Kozlowski wrote:
> On Tue, Dec 10, 2024 at 08:22:51PM +0800, Mao Jinlong wrote:
>> With current design, the name of the non-cpu bounded coresight
>> component is the device type with the number. And with 'ls' command
>> we can get the register address of the component. But from these
>> information, we can't know what the HW or system the component belongs
>> to. Add label in DT and show the hw information by reading label sysfs
>> node.
>>
>> cti_sys0 -> ../../../devices/platform/soc@...38f0000.cti/cti_sys0
>> cti_sys1 -> ../../../devices/platform/soc@...3900000.cti/cti_sys1
>> tpdm0 -> ../../../devices/platform/soc@...0b0d000.tpdm/tpdm0
>> tpdm1 -> ../../../devices/platform/soc@...0c28000.tpdm/tpdm1
>> tpdm2 -> ../../../devices/platform/soc@...0c29000.tpdm/tpdm2
>>
>> /sys/bus/coresight/devices # cat cti*/label
>> cti_dlct_0
>> cti_dlct_1
>> cti_apss_0
>> cti_apss_1
>> cti_apss_2
>>
>> Change since V4:
>> 1. Add label in DT and add label sysfs node for each coresight device.
> 
> This is v5, no links to previous versions (I really suggest to start
> using b4 if you want to make your process easier for you), no other
> changes so subject is obviously the same and looking for this patchset
> previous versions gives me 0 results:
> 
> https://lore.kernel.org/all/?q=%22coresight%3A+Add+label+sysfs+node+support%22
> 
> OK, let's try b4 diff:
> 
> b4 diff '20241210122253.31926-1-quic_jinlmao@...cinc.com'
> Grabbing thread from lore.kernel.org/all/20241210122253.31926-1-quic_jinlmao@...cinc.com/t.mbox.gz
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> Nothing matching that query.
> ---
> Analyzing 3 messages in the thread
> Could not find lower series to compare against.
> 
> 
> So how do you expect us to do any meaningful review?
> 
> Best regards,
> Krzysztof
I will resend the patches with the links of lower series.

>