linux-kernel - Re: [PATCH v2 0/3] bpftool: Fix the static linkage failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1mREhJElE6cSrPT@x1>
Date: Wed, 11 Dec 2024 10:18:10 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Leo Yan <leo.yan@....com>
Cc: Quentin Monnet <qmo@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	Nick Terrell <terrelln@...com>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	James Clark <james.clark@...aro.org>,
	Guilherme Amadio <amadio@...too.org>, linux-kernel@...r.kernel.org,
	bpf@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 0/3] bpftool: Fix the static linkage failure

On Wed, Dec 11, 2024 at 09:31:11AM +0000, Leo Yan wrote:
> This series follows up on the discussion in [1] for fixing the static
> linkage issue in bpftool.
> 
> Patch 01 introduces a new feature for libelf-zstd.  If this feature
> is detected, it means the zstd lib is required by libelf.
> 
> Patch 02 is a minor improvement for linking the zstd lib in the perf.
> 
> Patch 03 fixes the static build failure by linking the zstd lib when
> the feature-libelf-zstd is detected.
> 
> [1] https://lore.kernel.org/linux-perf-users/Z1H9-9xrWM4FBbNI@mini-arch/T/#m2300b127424e9e2ace7da497a20d88534eb6866f

So, this was originally reported as a perf build failure when trying a
static build, so something not so common, no urgency, I guess, but it
involves a tools/perf/bpftool/Makefile change, I think I can process
this as I'll then test it in the many build containers for old distros I
have, ok?

- Arnaldo
 
> 
> Leo Yan (3):
>   tools build: Add feature test for libelf with ZSTD
>   perf: build: Minor improvement for linking libzstd
>   bpftool: Link zstd lib required by libelf
> 
>  tools/bpf/bpftool/Makefile             | 8 ++++++++
>  tools/build/Makefile.feature           | 1 +
>  tools/build/feature/Makefile           | 4 ++++
>  tools/build/feature/test-all.c         | 4 ++++
>  tools/build/feature/test-libelf-zstd.c | 9 +++++++++
>  tools/perf/Makefile.config             | 8 +++++++-
>  6 files changed, 33 insertions(+), 1 deletion(-)
>  create mode 100644 tools/build/feature/test-libelf-zstd.c
> 
> -- 
> 2.34.1