[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8ecd5325-f347-4869-9049-2731b719f5d2@sirena.org.uk>
Date: Wed, 11 Dec 2024 13:25:44 +0000
From: Mark Brown <broonie@...nel.org>
To: Song Chen <chensong_2000@....cn>
Cc: krzk@...nel.org, lgirdwood@...il.com, lee@...nel.org,
linus.walleij@...aro.org, brgl@...ev.pl,
linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v2] regulator:s5m8767: Fully convert to GPIO descriptors
On Wed, Dec 11, 2024 at 01:10:19PM +0800, Song Chen wrote:
> This converts s5m8767 regulator driver to use GPIO descriptors.
>
> ---
> v1 - v2:
> 1, reedit commit message.
> 2, remove development code.
> 3, print error msg in dev_err_probe.
> 4, doesn't set gpiod directions until successfully requesting
> all gpiods. It's pretty much equivalent with original code.
>
> Signed-off-by: Song Chen <chensong_2000@....cn>
> ---
Your signoff needs to be before the ---, and the changelog after the
---. The tools will get very confused and remove your signoff here.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists