linux-kernel - Re: [PATCH v6 3/4] sched, psi: Don't account irq time if sched_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfvyt34exutgxu7ctow4llzpdttk6rhwrom62ppvr6rvp6ehre@uyu2sjyidssi>
Date: Wed, 11 Dec 2024 15:16:34 +0100
From: Michal Koutný <mkoutny@...e.com>
To: Yafang Shao <laoar.shao@...il.com>
Cc: mingo@...hat.com, peterz@...radead.org, hannes@...xchg.org, 
	juri.lelli@...hat.com, vincent.guittot@...aro.org, dietmar.eggemann@....com, 
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de, vschneid@...hat.com, 
	surenb@...gle.com, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org
Subject: Re: [PATCH v6 3/4] sched, psi: Don't account irq time if
 sched_clock_irqtime is disabled

On Wed, Dec 11, 2024 at 10:07:41PM GMT, Yafang Shao <laoar.shao@...il.com> wrote:
> My apologies, I'll fix it in the next version. How about the following
> change instead?
> 
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 7341d33d9118..263c26a36511 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -1233,6 +1233,9 @@ int psi_show(struct seq_file *m, struct
> psi_group *group, enum psi_res res)
>         if (static_branch_likely(&psi_disabled))
>                 return -EOPNOTSUPP;
> 
> +       if (!irqtime_enabled() && res == PSI_IRQ)
> +               return -EOPNOTSUPP;
> +
>         /* Update averages before reporting them */
>         mutex_lock(&group->avgs_lock);
>         now = sched_clock();

That looks correct.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)