linux-kernel - Re: [PATCH 07/15] ARM: zynq: Add ethernet phy reset information to DT(zc702)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5051fb04-1bcc-4448-aa68-6ff300cc17d2@amd.com>
Date: Wed, 11 Dec 2024 15:37:03 +0100
From: Michal Simek <michal.simek@....com>
To: Andrew Lunn <andrew@...n.ch>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
 git@...inx.com, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 07/15] ARM: zynq: Add ethernet phy reset information to
 DT(zc702)



On 12/11/24 15:21, Andrew Lunn wrote:
> On Wed, Dec 11, 2024 at 03:04:28PM +0100, Michal Simek wrote:
>> Hi Andrew,
>>
>> On 12/11/24 14:45, Andrew Lunn wrote:
>>> On Wed, Dec 11, 2024 at 01:41:26PM +0100, Michal Simek wrote:
>>>> Added phy reset gpio information for gem0.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@....com>
>>>> ---
>>>>
>>>>    arch/arm/boot/dts/xilinx/zynq-zc702.dts | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/xilinx/zynq-zc702.dts b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
>>>> index 424e78f6c148..975385f4ac01 100644
>>>> --- a/arch/arm/boot/dts/xilinx/zynq-zc702.dts
>>>> +++ b/arch/arm/boot/dts/xilinx/zynq-zc702.dts
>>>> @@ -79,6 +79,8 @@ &gem0 {
>>>>    	phy-handle = <&ethernet_phy>;
>>>>    	pinctrl-names = "default";
>>>>    	pinctrl-0 = <&pinctrl_gem0_default>;
>>>> +	phy-reset-gpio = <&gpio0 11 0>;
>>>> +	phy-reset-active-low;
>>>
>>> Hi Michal
>>>
>>> Could you point me at code which actually implements these two
>>> properties.
>>
>> I have tracked it down and it was only used from 2016 to 2018 in Xilinx
>> downstream Linux repository. After that it was removed.
> 
> O.K. So when you ran the DT lint tools to validate these DT changes,
> why did it not give errors pointing this out?
> 
> I wounder how many other such errors there are in this patchset?

That's definitely valid concern.
I was running it but for all files there are a lot of other issues generated 
that I missed this one.

../linux/arch/arm/boot/dts/xilinx/zynq-zc702.dtb: ethernet@...0b000: Unevaluated 
properties are not allowed ('phy-reset-active-low', 'phy-reset-gpio' were 
unexpected)

Thanks,
Michal