linux-kernel - Re: [PATCH v7 2/3] clk: qcom: common: Add support for power-domain attachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <beaf4e8a-51a5-431e-8538-269d2db94f15@linaro.org>
Date: Wed, 11 Dec 2024 14:54:08 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/3] clk: qcom: common: Add support for power-domain
 attachment

On 11/12/2024 13:36, Vladimir Zapolskiy wrote:
>> +    struct dev_pm_domain_attach_data pd_data = {
>> +        .pd_names = 0,
>> +        .num_pd_names = 0,
>> +    };
> 
> Please remove the added local variable.
> 
>>       cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL);
>>       if (!cc)
>>           return -ENOMEM;
>> +    ret = devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list);
> 
> Please simplify it to
> 
>      ret = devm_pm_domain_attach_list(dev, NULL, &cc->pd_list);

My apologies, I cherry-picked the wrong version of this patch from my 
working tree to my b4/send tree.

---
bod