linux-kernel - Re: [PATCH] x86/entry: Add __init to ia32_emulation_override

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df3b71b2-086e-4439-89bc-b55f192f6ab6@suse.com>
Date: Wed, 11 Dec 2024 17:03:20 +0200
From: Nikolay Borisov <nik.borisov@...e.com>
To: Vitaly Kuznetsov <vkuznets@...hat.com>, Andy Lutomirski
 <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>
Cc: x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
 Michael Petlan <mpetlan@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/entry: Add __init to
 ia32_emulation_override_cmdline()

On 10.12.24 г. 17:16 ч., Vitaly Kuznetsov wrote:
> ia32_emulation_override_cmdline() is an early_param() arg and these
> are only needed at boot time. In fact, all other early_param() functions
> in arch/x86 seem to have '__init' annotation and
> ia32_emulation_override_cmdline() is the only exception.
> 
> Fixes: a11e097504ac ("x86: Make IA32_EMULATION boot time configurable")
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>

nit: Does it really warrant a Fix tag, it's not a bug per-se, just frees 
up some memory?