linux-kernel - Re: [PATCH 1/2] riscv: signal: fix signal frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTtA3NVns7er2o+0Fu64uzy+83ScinRp=u5wcRd=MFCWnZraA@mail.gmail.com>
Date: Wed, 11 Dec 2024 23:23:39 +0800
From: Andy Chiu <andybnac@...il.com>
To: Yong-Xuan Wang <yongxuan.wang@...ive.com>
Cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	greentime.hu@...ive.com, vincent.chen@...ive.com, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Zong Li <zong.li@...ive.com>, 
	Conor Dooley <conor.dooley@...rochip.com>, Zhongqiu Han <quic_zhonhan@...cinc.com>, 
	Björn Töpel <bjorn@...osinc.com>, 
	Ben Dooks <ben.dooks@...ethink.co.uk>, Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH 1/2] riscv: signal: fix signal frame size

Hi Young-Xuan,

Yong-Xuan Wang <yongxuan.wang@...ive.com> 於 2024年12月10日 週二 下午10:24寫道：
>
> The signal context of certain RISC-V extensions will be appended after
> struct __riscv_extra_ext_header, which already includes an empty context
> header. Therefore, there is no need to preserve a separate hdr for the
> END of signal context.
>
> Fixes: 8ee0b41898fa ("riscv: signal: Add sigcontext save/restore for vector")
> Signed-off-by: Yong-Xuan Wang <yongxuan.wang@...ive.com>
> Reviewed-by: Zong Li <zong.li@...ive.com>
> ---
>  arch/riscv/kernel/signal.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c
> index dcd282419456..c3c517b9eee5 100644
> --- a/arch/riscv/kernel/signal.c
> +++ b/arch/riscv/kernel/signal.c
> @@ -215,12 +215,6 @@ static size_t get_rt_frame_size(bool cal_all)
>                 if (cal_all || riscv_v_vstate_query(task_pt_regs(current)))
>                         total_context_size += riscv_v_sc_size;
>         }
> -       /*
> -        * Preserved a __riscv_ctx_hdr for END signal context header if an
> -        * extension uses __riscv_extra_ext_header
> -        */
> -       if (total_context_size)
> -               total_context_size += sizeof(struct __riscv_ctx_hdr);
>
>         frame_size += total_context_size;
>
> --
> 2.17.1
>

Thanks for the findings

Reviewed-by: Andy Chiu <AndybnAC@...il.com>