linux-kernel - Re: [PATCH] PCI: endpoint: Replace magic number "6" by PCI_STD_NUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241212190032.GA3356901@bhelgaas>
Date: Thu, 12 Dec 2024 13:00:32 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Rick Wertenbroek <rick.wertenbroek@...il.com>
Cc: rick.wertenbroek@...g-vd.ch, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Replace magic number "6" by
 PCI_STD_NUM_BARS

On Thu, Dec 12, 2024 at 05:25:47PM +0100, Rick Wertenbroek wrote:
> Replace the constant "6" by PCI_STD_NUM_BARS, as defined in
> include/uapi/linux/pci_regs.h:
> 
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@...il.com>

Applied to pci/endpoint for v6.14, thanks!

> ---
>  include/linux/pci-epf.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h
> index 18a3aeb62ae4..ee6156bcbbd0 100644
> --- a/include/linux/pci-epf.h
> +++ b/include/linux/pci-epf.h
> @@ -157,7 +157,7 @@ struct pci_epf {
>  	struct device		dev;
>  	const char		*name;
>  	struct pci_epf_header	*header;
> -	struct pci_epf_bar	bar[6];
> +	struct pci_epf_bar	bar[PCI_STD_NUM_BARS];
>  	u8			msi_interrupts;
>  	u16			msix_interrupts;
>  	u8			func_no;
> @@ -174,7 +174,7 @@ struct pci_epf {
>  	/* Below members are to attach secondary EPC to an endpoint function */
>  	struct pci_epc		*sec_epc;
>  	struct list_head	sec_epc_list;
> -	struct pci_epf_bar	sec_epc_bar[6];
> +	struct pci_epf_bar	sec_epc_bar[PCI_STD_NUM_BARS];
>  	u8			sec_epc_func_no;
>  	struct config_group	*group;
>  	unsigned int		is_bound;
> -- 
> 2.25.1
>