linux-kernel - Re: [PATCH 6.1.y] net: napi: Prevent overflow of napi_defer_hard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241211200739.47686258@kernel.org>
Date: Wed, 11 Dec 2024 20:07:39 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: <jianqi.ren.cn@...driver.com>
Cc: <gregkh@...uxfoundation.org>, <stable@...r.kernel.org>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <sashal@...nel.org>, <jamie.bainbridge@...il.com>, <jdamato@...tly.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6.1.y] net: napi: Prevent overflow of
 napi_defer_hard_irqs

On Wed, 11 Dec 2024 12:03:04 +0800 jianqi.ren.cn@...driver.com wrote:
> From: Joe Damato <jdamato@...tly.com>
> 
> [ Upstream commit 08062af0a52107a243f7608fd972edb54ca5b7f8 ]
> 
> In commit 6f8b12d661d0 ("net: napi: add hard irqs deferral feature")
> napi_defer_irqs was added to net_device and napi_defer_irqs_count was
> added to napi_struct, both as type int.
> 
> This value never goes below zero, so there is not reason for it to be a
> signed int. Change the type for both from int to u32, and add an
> overflow check to sysfs to limit the value to S32_MAX.

Could you explain why you want to backport this change to stable?