linux-kernel - Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28b1c828-f338-4d57-bcb7-b0a8652c82fb@quicinc.com>
Date: Thu, 12 Dec 2024 19:28:38 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <vladimir.zapolskiy@...aro.org>
CC: <quic_eberman@...cinc.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>,
        Yongsheng Li
	<quic_yon@...cinc.com>
Subject: Re: [PATCH 15/16] media: qcom: camss: Add CSID 780 support

Hi Bryan,

On 12/12/2024 5:57 AM, Bryan O'Donoghue wrote:
> On 11/12/2024 14:07, Depeng Shao wrote:
>> +static int csid_configure_testgen_pattern(struct csid_device *csid, 
>> s32 val)
>> +{
>> +    return 0;
>> +}
> 
> Could we avoid this empty callback by checking csid->ctrl in csid.c ?
> 
> If so, please make that change.
> 
> If not, it's fine.
> 
> For either case.
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>

Vladimir suggested to add a dummy "return 0" function [1] for the 
unsupported interface. So, I added this empty callback, will keep the 
empty callback if no other concern. Thanks.

[1] 
https://lore.kernel.org/all/b1e1ff88-5bba-4424-bc85-38caa85b831f@linaro.org/


Thanks,
Depeng