linux-kernel - Re: [PATCH V2 2/8] accel/amdxdna: Replace mmput with mmput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f82f3a18-82d5-4677-79c2-896c52821b27@quicinc.com>
Date: Fri, 13 Dec 2024 09:33:03 -0700
From: Jeffrey Hugo <quic_jhugo@...cinc.com>
To: Lizhi Hou <lizhi.hou@....com>, <ogabbay@...nel.org>,
        <dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
        <sonal.santan@....com>, <king.tam@....com>,
        <mario.limonciello@....com>
Subject: Re: [PATCH V2 2/8] accel/amdxdna: Replace mmput with mmput_async to
 avoid dead lock

On 12/6/2024 2:59 PM, Lizhi Hou wrote:
> Hardware mailbox message receiving handler calls mmput to release the
> process mm. If the process has already exited, the mmput here may call mmu
> notifier handler, amdxdna_hmm_invalidate, which will cause a dead lock.
> Using mmput_async instead prevents this dead lock.
> 
> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
> Signed-off-by: Lizhi Hou <lizhi.hou@....com>

Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>