linux-kernel - Re: [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b59099a-ca9b-576c-9583-fb54c8c594e6@amd.com>
Date: Fri, 13 Dec 2024 08:42:30 -0800
From: Lizhi Hou <lizhi.hou@....com>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>, <ogabbay@...nel.org>,
	<dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <min.ma@....com>, <max.zhen@....com>,
	<sonal.santan@....com>, <king.tam@....com>, <mario.limonciello@....com>,
	"Mike Lothian" <mike@...eburn.co.uk>
Subject: Re: [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to
 amdxdna_mailbox.c


On 12/13/24 08:20, Jeffrey Hugo wrote:
> On 12/6/2024 3:00 PM, Lizhi Hou wrote:
>> For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by
>> trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will
>> fail.
>>
>> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
>> Reported-by: Mike Lothian <mike@...eburn.co.uk>
>> Closes: 
>> https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/
>> Signed-off-by: Mike Lothian <mike@...eburn.co.uk>
>> Signed-off-by: Lizhi Hou <lizhi.hou@....com>
>
> Slight problem with the SOB chain which prevents me from applying this.
>
> Mike comes first, which indicates he authored this patch.  Then you, 
> which says you took Mike's patch and are moving it forward. However, 
> since you sent it and it doesn't have "From: Mike", you get listed as 
> author.
>
> Either Mike needs to be the listed author, or a Co-developed-by tag 
> for Mike needs to be listed immediately before his SOB.
>
> With either of those:
>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>

Got it. I added "From: Mike" and created a standalone patch for this 
fix. 
https://lore.kernel.org/dri-devel/20241213163856.1472207-1-lizhi.hou@amd.com/


Thanks,

Lizhi