linux-kernel - Re: [PATCH v1 1/4] hwmon: pmbus-core: Add label for fan and temp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2713e85d-f88a-49d6-8221-151e8631758c@roeck-us.net>
Date: Fri, 13 Dec 2024 09:08:30 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Ninad Palsule <ninad@...ux.ibm.com>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, eajames@...ux.ibm.com, jdelvare@...e.com,
 corbet@....net, joel@....id.au, andrew@...econstruct.com.au,
 Delphine_CC_Chiu@...ynn.com, broonie@...nel.org, peteryin.openbmc@...il.com,
 noahwang.wang@...look.com, naresh.solanki@...ements.com, lukas@...ner.de,
 jbrunet@...libre.com, patrick.rudolph@...ements.com,
 gregkh@...uxfoundation.org, peterz@...radead.org, pbiel7@...il.com,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-i2c@...r.kernel.org
Subject: Re: [PATCH v1 1/4] hwmon: pmbus-core: Add label for fan and temp

On 12/13/24 08:12, Ninad Palsule wrote:
> Hello Guenter,
> 
> On 12/12/24 16:06, Guenter Roeck wrote:
>> On 12/12/24 13:49, Ninad Palsule wrote:
>>> Adding label files for fan and temperature sensors in the power supply.
>>> The openbmc application dbus-sensor(psusensor) requires those files to
>>> consfigure those sensors.
>>> Note that prefix for temp label is temp[A..C] used instead of temp[1..3]
>>> as dbus-sensor(psusensor) application calculate index based on last
>>> digit in the name so we do not want to make index double digit after
>>> appending page index.
>>>
>>> Signed-off-by: Ninad Palsule <ninad@...ux.ibm.com>
>>
>> We are not going to fix userspace problems in the kernel.
>>
>> Guenter
>>
> 
> Thanks for the quick review.
> 
> Sorry I am not clear on this. I feel that it is better to support labels for temperature
> 
> sensors and fans like other. Are you saying we should not support these labels or
> 
> I need update in the patch to support them better?
> 

There should be no such labels. Labels are supposed to have specific meanings,
such as "this is the CPU temperature sensor", not vague meanings such as "tempA".

Guenter