linux-kernel - Re: [PATCH v3 09/11] wifi: qtnfmac: use always-managed version of pcim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241213175349.GA3421319@bhelgaas>
Date: Fri, 13 Dec 2024 11:53:49 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Kalle Valo <kvalo@...nel.org>
Cc: Philipp Stanner <pstanner@...hat.com>,
	Igor Mitsyanko <imitsyanko@...ntenna.com>,
	amien Le Moal <dlemoal@...nel.org>,
	Niklas Cassel <cassel@...nel.org>,
	Basavaraj Natikar <basavaraj.natikar@....com>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Sergey Matyukevich <geomatsi@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alex Dubov <oakad@...oo.com>,
	Sudarsana Kalluru <skalluru@...vell.com>,
	Manish Chopra <manishc@...vell.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rasesh Mody <rmody@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
	Sanjay R Mehta <sanju.mehta@....com>,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>,
	Jon Mason <jdmason@...zu.us>, Dave Jiang <dave.jiang@...el.com>,
	Allen Hubbe <allenbh@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	Juergen Gross <jgross@...e.com>,
	Stefano Stabellini <sstabellini@...nel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>,
	Mario Limonciello <mario.limonciello@....com>,
	Chen Ni <nichen@...as.ac.cn>, Ricky Wu <ricky_wu@...ltek.com>,
	Al Viro <viro@...iv.linux.org.uk>, Breno Leitao <leitao@...ian.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Kevin Tian <kevin.tian@...el.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Mostafa Saleh <smostafa@...gle.com>, Jason Gunthorpe <jgg@...pe.ca>,
	Yi Liu <yi.l.liu@...el.com>, Kunwu Chan <chentao@...inos.cn>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Ankit Agrawal <ankita@...dia.com>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Eric Auger <eric.auger@...hat.com>, Ye Bin <yebin10@...wei.com>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org, ntb@...ts.linux.dev,
	linux-pci@...r.kernel.org, kvm@...r.kernel.org,
	xen-devel@...ts.xenproject.org,
	Igor Mitsyanko <i.mitsyanko@...il.com>
Subject: Re: [PATCH v3 09/11] wifi: qtnfmac: use always-managed version of
 pcim_intx()

[+cc personal address for Igor]

On Fri, Dec 13, 2024 at 12:30:42PM +0200, Kalle Valo wrote:
> Bjorn Helgaas <helgaas@...nel.org> writes:
> 
> > [cc->to: Igor]
> >
> > On Mon, Dec 09, 2024 at 02:06:31PM +0100, Philipp Stanner wrote:
> >> pci_intx() is a hybrid function which can sometimes be managed through
> >> devres. To remove this hybrid nature from pci_intx(), it is necessary to
> >> port users to either an always-managed or a never-managed version.
> >> 
> >> qtnfmac enables its PCI-Device with pcim_enable_device(). Thus, it needs
> >> the always-managed version.
> >> 
> >> Replace pci_intx() with pcim_intx().
> >> 
> >> Signed-off-by: Philipp Stanner <pstanner@...hat.com>
> >> Acked-by: Kalle Valo <kvalo@...nel.org>
> >
> > Hoping for an ack from Igor, too.
> 
> Igor hasn't been around for a while so I'm not expecting see an ack from
> him, I think the whole qtnfmac driver should be removed in the future.
> Feel free to take the patch as is.

Thanks, Kalle, will do.