linux-kernel - Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95951cd6-f98f-4793-a35c-22f4e8d743af@csgroup.eu>
Date: Fri, 13 Dec 2024 19:01:42 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Michael Ellerman <mpe@...erman.id.au>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>
Subject: Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header



Le 13/12/2024 à 18:07, Andy Shevchenko a écrit :
> On Fri, Dec 13, 2024 at 07:28:45AM +0100, Christophe Leroy wrote:
>> Le 12/12/2024 à 17:24, Andy Shevchenko a écrit :
>>> On Mon, Nov 18, 2024 at 03:10:09PM +0100, Christophe Leroy wrote:
>>>> Le 18/11/2024 à 13:31, Andy Shevchenko a écrit :
>>>>> Remove legacy-of-mm-gpiochip.h header file. The above mentioned
>>>>> file provides an OF API that's deprecated. There is no agnostic
>>>>> alternatives to it and we have to open code the logic which was
>>>>> hidden behind of_mm_gpiochip_add_data(). Note, most of the GPIO
>>>>> drivers are using their own labeling schemas and resource retrieval
>>>>> that only a few may gain of the code deduplication, so whenever
>>>>> alternative is appear we can move drivers again to use that one.
>>>>>
>>>>> As a side effect this change fixes a potential memory leak on
>>>>> an error path, if of_mm_gpiochip_add_data() fails.
>>>>>
>>>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>>>
>>>> Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
>>>
>>> Thanks, what's next?
>>
>> Next step is that Michael or Madhavan apply it I guess ?
> 
> Folks, do you have any comments? Can you apply this and we move forward towards
> removing the legacy API from the kernel?
> 

If you have some work which depends on this patch, you can also take it 
together with that work through another tree. Just let us know.

Acked-by: Christophe Leroy <christophe.leroy@...roup.eu>