linux-kernel - [PATCH] tty: Make sysctl table const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241213-sysctl_const-tty-v1-1-2e2bcec77f85@suse.com>
Date: Fri, 13 Dec 2024 16:35:05 -0300
From: "Ricardo B. Marliere" <rbm@...e.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Jiri Slaby <jirislaby@...nel.org>
Cc: Luis Felipe Hernandez <luis.hernandez093@...il.com>, 
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
 Thomas Weißschuh <linux@...ssschuh.net>, 
 "Ricardo B. Marliere" <rbm@...e.com>
Subject: [PATCH] tty: Make sysctl table const

Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
ctl_table"), the sysctl registration API allows for struct ctl_table to be
in read-only memory. Move tty_table to be declared at build time, instead
of having to be dynamically allocated at boot time.

Cc: Thomas Weißschuh <linux@...ssschuh.net>
Suggested-by: Thomas Weißschuh <linux@...ssschuh.net>
Signed-off-by: Ricardo B. Marliere <rbm@...e.com>
---
 drivers/tty/tty_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index dcb1769c3625cd0f7d1555260adfe6051139a305..0e84677712b4e1eb72f209c4d9c54a940b3a9041 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -3618,7 +3618,7 @@ void console_sysfs_notify(void)
 		sysfs_notify(&consdev->kobj, NULL, "active");
 }

-static struct ctl_table tty_table[] = {
+static const struct ctl_table tty_table[] = {
 	{
 		.procname	= "legacy_tiocsti",
 		.data		= &tty_legacy_tiocsti,

---
base-commit: 535a07698b8b3e6f305673102d297262cae2360a
change-id: 20241213-sysctl_const-tty-67dfc1bc83b5

Best regards,
-- 
Ricardo B. Marliere <rbm@...e.com>