linux-kernel - Re: [PATCH 1/1 next] perf tests switch-tracking: Set this test to run exclusively

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z1yPYqYYs_isO1PJ@x1>
Date: Fri, 13 Dec 2024 16:47:46 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1 next] perf tests switch-tracking: Set this test to
 run exclusively

On Fri, Dec 13, 2024 at 10:10:32AM -0800, Ian Rogers wrote:
> On Fri, Dec 13, 2024 at 10:06 AM Arnaldo Carvalho de Melo
> <acme@...nel.org> wrote:
> >
> > This test was failing when run with the default 'perf test' mode, which
> > is to run multiple regression tests in parallel.
> >
> > Since it checks system_wide mode, set it to run in exclusive mode.
> >
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: Ian Rogers <irogers@...gle.com>
> > Cc: James Clark <james.clark@...aro.org>
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Kan Liang <kan.liang@...ux.intel.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > ---
> >  tools/perf/tests/switch-tracking.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/tests/switch-tracking.c b/tools/perf/tests/switch-tracking.c
> > index 5cab17a1942e67d7..88a03bcbecb2b11f 100644
> > --- a/tools/perf/tests/switch-tracking.c
> > +++ b/tools/perf/tests/switch-tracking.c
> > @@ -583,4 +583,11 @@ static int test__switch_tracking(struct test_suite *test __maybe_unused, int sub
> >         goto out;
> >  }
> >
> > -DEFINE_SUITE("Track with sched_switch", switch_tracking);
> > +struct test_case tests__switch_tracking[] = {
> > +        TEST_CASE_EXCLUSIVE("Track with sched_switch", switch_tracking),
> > +        {       .name = NULL, }
> > +};
> > +struct test_suite suite__switch_tracking = {
> > +        .desc = "Track with sched_switch",
> > +        .test_cases = tests__switch_tracking,
> > +};
> 
> With Ravi's change:
> https://lore.kernel.org/lkml/20241210093449.1662-10-ravi.bangoria@amd.com/
> This could be s/DEFINE_SUITE/DEFINE_SUITE_EXCLUSIVE/ , wdyt?

Sure, I saw that, forgot about it, then when looking for
DEFINE_SUITE_EXCLUSIVE and not finding it, I just copy'n'pasted from
what was in some other test.

I'll backtrack, add Ravi's patch, then resubmit.

Thanks!	

- Arnaldo