linux-kernel - Re: [PATCH v12 2/2] rust: xarray: Add an abstraction for XArray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9kU6JrKLUVw-Rvph8Fi5EZX1EgJey2KCHUFn7J=BYjx5g@mail.gmail.com>
Date: Fri, 13 Dec 2024 14:47:49 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Danilo Krummrich <dakr@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Trevor Gross <tmgross@...ch.edu>, 
	Maíra Canal <mcanal@...lia.com>, 
	Asahi Lina <lina@...hilina.net>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 2/2] rust: xarray: Add an abstraction for XArray

On Fri, Dec 13, 2024 at 2:38 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
> Personally, I would rewrite at least the `if` one, since it is not
> really how we write those elsewhere. The other one, since you are
> building an iterator anyway, I think it makes sense. For similar
> reasons, perhaps one `match` you have could be an early return
> instead.

I'll make these changes.

> But it is up to the maintainer. By the way, I don't see the XARRAY
> maintainer nor the list Cc'd?

Oops, this was an unintended omission. I'll resend this and include those folks.