linux-kernel - Re: [PATCH] bcachefs: fix invalid declaration after label in str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf18e0fb-d436-46ea-9c8f-408e948965db@huawei.com>
Date: Fri, 13 Dec 2024 11:27:28 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: Zhou Ding <zhouding@...s.chinamobile.com>, <kent.overstreet@...ux.dev>
CC: <linux-bcachefs@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bcachefs: fix invalid declaration after label in
 str_hash.c



On 2024/12/12 18:49, Zhou Ding wrote:
> We get 1 error when building kernel withW=1:
> fs/bcachefs/str_hash.c:164:2: error: a label can only be part of a statement and a declaration is not a statement
> 
> To resolve this, the code after the found: label was enclosed in a block
> to comply with C89 rules, without affecting the logic of the code.
> 
> Signed-off-by: Zhou Ding <zhouding@...s.chinamobile.com>
> ---
>   fs/bcachefs/str_hash.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/str_hash.c b/fs/bcachefs/str_hash.c
> index ed3c852fc0be..08625947ed99 100644
> --- a/fs/bcachefs/str_hash.c
> +++ b/fs/bcachefs/str_hash.c
> @@ -160,7 +160,7 @@ static int check_inode_hash_info_matches_root(struct btree_trans *trans, u64 inu
>   	bch_err(c, "%s(): inum %llu not found", __func__, inum);
>   	ret = -BCH_ERR_fsck_repair_unimplemented;
>   	goto err;
> -found:
It has been fixed in [1].:)

Thanks,
Hongbo

[1] 
https://lore.kernel.org/linux-bcachefs/qnfn3xzh6ve5cukeugxucloynbstf2itos3ddlmzu2w4sp7md7@7bkk2byif2ja/T/#t
> +found:{
>   	struct bch_inode_unpacked inode;
>   	ret = bch2_inode_unpack(k, &inode);
>   	if (ret)
> @@ -174,6 +174,7 @@ static int check_inode_hash_info_matches_root(struct btree_trans *trans, u64 inu
>   			ret = -BCH_ERR_fsck_repair_unimplemented;
>   		}
>   	}
> +}
>   err:
>   	bch2_trans_iter_exit(trans, &iter);
>   	return ret;