linux-kernel - Re: [PATCH 3/8] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB QMP PHY supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM7P189MB1009F7FB7D074522E0641BC7E3382@AM7P189MB1009.EURP189.PROD.OUTLOOK.COM>
Date: Fri, 13 Dec 2024 21:39:06 +0100
From: Maud Spierings <maud_spierings@...mail.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Sibi Sankar <quic_sibis@...cinc.com>,
 Marc Zyngier <maz@...nel.org>, Xilin Wu <wuxilin123@...il.com>,
 Abel Vesa <abel.vesa@...aro.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Aleksandrs Vinarskis <alex.vinarskis@...il.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH 3/8] arm64: dts: qcom: x1e80100-asus-vivobook-s15: Fix USB
 QMP PHY supplies


On 12/10/24 10:07, Stephan Gerhold wrote:
> On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1
> (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2
> are actually powered by &vreg_l2j_1p2.
>
> Since x1e80100-asus-vivobook-s15 mostly just mirrors the power supplies
> from the x1e80100-crd device tree, assume that the fix also applies here.
>
> Cc: stable@...r.kernel.org
> Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> index f25991b887de3fca0092c5f81c881c5d8bd71aac..bcb25782d541f43166229695ea1b83ee7b94a6c8 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> @@ -599,7 +599,7 @@ &usb_1_ss0_hsphy {
>   };
>   
>   &usb_1_ss0_qmpphy {
> -	vdda-phy-supply = <&vreg_l3e_1p2>;
> +	vdda-phy-supply = <&vreg_l2j_1p2>;
>   	vdda-pll-supply = <&vreg_l1j_0p8>;
>   
>   	status = "okay";
> @@ -631,7 +631,7 @@ &usb_1_ss1_hsphy {
>   };
>   
>   &usb_1_ss1_qmpphy {
> -	vdda-phy-supply = <&vreg_l3e_1p2>;
> +	vdda-phy-supply = <&vreg_l2j_1p2>;
>   	vdda-pll-supply = <&vreg_l2d_0p9>;
>   
>   	status = "okay";
>
I can't really verify with documentation if it is actually correct but 
given the similarities in all these systems I have no reason to assume not.

It doesn't seem to cause any weird errors or anything, so


Tested-by: Maud Spierings <maud_spierings@...mail.com>