linux-kernel - Re: [PATCH v13 0/2] rust: xarray: Add a minimal abstraction for XArray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9kSWw+txqFOrh4fGUfPb2zQ8rDSgUo0HLMGMUG=EThO-Q@mail.gmail.com>
Date: Fri, 13 Dec 2024 18:22:20 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Danilo Krummrich <dakr@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Matthew Wilcox <willy@...radead.org>, Maíra Canal <mcanal@...lia.com>, 
	Asahi Lina <lina@...hilina.net>, rust-for-linux@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 0/2] rust: xarray: Add a minimal abstraction for XArray

On Fri, Dec 13, 2024 at 4:31 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Fri, Dec 13, 2024 at 9:02 PM Tamir Duberstein <tamird@...il.com> wrote:
> >
> > Changes in v13:
> > - Replace `bool::then` with `if`. (Miguel Ojeda)
> > - Replace `match` with `let` + `if`. (Miguel Ojeda)
>
> Personally, I would also use the early return style in both of these,
> like in C.

My personal preference is to leave it as-is as the return keyword
isn't used anywhere in this file at the moment. I don't mind you
changing it if/when applying, though.

> I think you may also omit the parenthesis in the first one.

Oops, you're right.