linux-kernel - RE: [PATCH v2] EDAC/{i10nm,skx,skx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB71348EA08231D40941DE43D189382@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Fri, 13 Dec 2024 05:17:25 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: "Meyer, Kyle" <kyle.meyer@....com>, "Luck, Tony" <tony.luck@...el.com>,
	"bp@...en8.de" <bp@...en8.de>, "james.morse@....com" <james.morse@....com>,
	"mchehab@...nel.org" <mchehab@...nel.org>, "rric@...nel.org"
	<rric@...nel.org>, "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "Meyer, Kyle" <kyle.meyer@....com>
Subject: RE: [PATCH v2] EDAC/{i10nm,skx,skx_common}: Support UV systems

> From: Kyle Meyer <kyle.meyer@....com>
> Sent: Friday, December 13, 2024 9:26 AM
> To: Luck, Tony <tony.luck@...el.com>; bp@...en8.de;
> james.morse@....com; mchehab@...nel.org; rric@...nel.org; Zhuo, Qiuxu
> <qiuxu.zhuo@...el.com>; linux-edac@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Meyer, Kyle <kyle.meyer@....com>
> Subject: [PATCH v2] EDAC/{i10nm,skx,skx_common}: Support UV systems
> 
> The 3-bit source IDs in PCI configuration space registers, used to map devices
> to sockets, are limited to 8 unique IDs, and each ID is local to a UPI/QPI
> domain.
> 
> Source IDs cannot be used to map devices to sockets on UV systems because
> they can exceed 8 sockets and have multiple UPI/QPI domains with identical,
> repeating source IDs.
> 
> Use NUMA information to get package IDs instead of source IDs on UV
> systems, and use package/source IDs to name IMC information structures.
> 
> Signed-off-by: Kyle Meyer <kyle.meyer@....com>

Thanks for this patch. LGTM. 
I tested it on a non-UV system and didn't observe any regressions.

Tested-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>

Thanks!
-Qiuxu