linux-kernel - Re: [PATCH v13 01/25] virt: geniezone: enable gzvm-ko in defconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d711de9ef517cc85fbb16a30ac21bd4c44c8f863.camel@mediatek.com>
Date: Fri, 13 Dec 2024 05:57:31 +0000
From: Liju-clr Chen (陳麗如)
	<Liju-clr.Chen@...iatek.com>
To: "corbet@....net" <corbet@....net>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "rostedt@...dmis.org"
	<rostedt@...dmis.org>, "krzk@...nel.org" <krzk@...nel.org>,
	Ze-yu Wang (王澤宇) <Ze-yu.Wang@...iatek.com>,
	"catalin.marinas@....com" <catalin.marinas@....com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "robh@...nel.org" <robh@...nel.org>,
	"richardcochran@...il.com" <richardcochran@...il.com>, "mhiramat@...nel.org"
	<mhiramat@...nel.org>, Yingshiuan Pan (潘穎軒)
	<Yingshiuan.Pan@...iatek.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
	"will@...nel.org" <will@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Kevenny Hsieh (謝宜芸)
	<Kevenny.Hsieh@...iatek.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, PeiLun Suei (隋培倫)
	<PeiLun.Suei@...iatek.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Shawn Hsiao (蕭志祥)
	<shawn.hsiao@...iatek.com>, "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>, Chi-shen Yeh (葉奇軒)
	<Chi-shen.Yeh@...iatek.com>
Subject: Re: [PATCH v13 01/25] virt: geniezone: enable gzvm-ko in defconfig

On Wed, 2024-12-11 at 09:38 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 14/11/2024 11:07, Liju-clr Chen wrote:
> > From: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> > 
> 
> Please use subject prefixes matching the subsystem. You can get them
> for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> directory
> your patch is touching.
> 
> 
> > Add config in defconfig to enable gzvm driver by default
> 
> This we see from the diff. You must explain why we want it.
> 
> > 
> > Signed-off-by: Yingshiuan Pan <yingshiuan.pan@...iatek.com>
> > Signed-off-by: Yi-De Wu <yi-de.wu@...iatek.com>
> > Signed-off-by: Liju Chen <liju-clr.chen@...iatek.com>
> > ---
> >  arch/arm64/configs/defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig
> > index d13218d0c30f..0f63d4837b61 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1733,3 +1733,5 @@ CONFIG_CORESIGHT_STM=m
> >  CONFIG_CORESIGHT_CPU_DEBUG=m
> >  CONFIG_CORESIGHT_CTI=m
> >  CONFIG_MEMTEST=y
> > +CONFIG_VIRT_DRIVERS=y
> > +CONFIG_MTK_GZVM=m
> 
> Does not look like placed correctly, according to savedefconfig.
> 
> I still do not see any reason to have it enabled.
> 
> Your patches have weird order or this is just wrong. There is no such
> thing as "MTK_GZVM". Use git grep, if you do not believe me.
> 
> 
> Best regards,
> Krzysztof

Hi Krzysztof,
Thank you for your comments. I agree with your suggestions.
We will remove this patch in the next version.

Best regards,
Liju Chen