linux-kernel - Re: [PATCH] staging: gpib: Replace semaphore with completion for one-time signaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <675aedb1-b7dd-4565-b028-1a718fe3fb09@stanley.mountain>
Date: Fri, 13 Dec 2024 10:02:05 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: eisantosh95@...il.com
Cc: Dave Penkler <dpenkler@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Shuah Khan <skhan@...uxfoundation.org>,
	"Everest K.C." <everestkc@...restkc.com.np>,
	Kees Bakker <kees@...erbout.nl>, Arnd Bergmann <arnd@...db.de>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Replace semaphore with completion for
 one-time signaling

On Thu, Dec 12, 2024 at 09:51:04PM +0530, eisantosh95@...il.com wrote:
> From: Santosh Mahto <eisantosh95@...il.com>
> 
> Replaced 'down_interruptible()' and 'up()' calls
> with 'wait_for_completion_interruptible()' and
> 'complete()' respectively. The completion API
> simplifies the code and adheres to kernel best
> practices for synchronization primitive
> 
> Signed-off-by: Santosh Mahto <eisantosh95@...il.com>

Looks okay to me.

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter