linux-kernel - Re: [PATCH] efi/esrt: remove esre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXHJi0_yuNWWOUefAqyha3usH5b32C1xVgnA9vnO+y-ZBw@mail.gmail.com>
Date: Fri, 13 Dec 2024 08:45:08 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efi/esrt: remove esre_attribute::store()

On Wed, 11 Dec 2024 at 08:05, Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:
>
> esre_attribute::store() is not needed since commit af97a77bc01c (efi:
> Move some sysfs files to be read-only by root). Drop it.
>
> Found by https://github.com/jirislaby/clang-struct.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: linux-efi@...r.kernel.org

Queued up, thanks.

> ---
>  drivers/firmware/efi/esrt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index 7a81c0ce4780..4bb7b0584bc9 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -75,8 +75,6 @@ static LIST_HEAD(entry_list);
>  struct esre_attribute {
>         struct attribute attr;
>         ssize_t (*show)(struct esre_entry *entry, char *buf);
> -       ssize_t (*store)(struct esre_entry *entry,
> -                        const char *buf, size_t count);
>  };
>
>  static struct esre_entry *to_entry(struct kobject *kobj)
> --
> 2.47.1
>