linux-kernel - Re: [PATCH 2/2] nvmem: imx-ocotp-ele: Support accessing controller for i.MX9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf153dd6-f82c-47d9-9ab4-f247437d607e@kernel.org>
Date: Fri, 13 Dec 2024 08:52:49 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>,
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>
Cc: devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 2/2] nvmem: imx-ocotp-ele: Support accessing controller
 for i.MX9

On 12/12/2024 09:24, Peng Fan (OSS) wrote:
> +
> +			if (imx_ele_ocotp_check_access(pdev, id)) {
> +				of_detach_node(child);
> +				dev_err(dev, "%s: Not granted, device driver will not be probed\n",
> +					child->full_name);
> +			}
> +		}
> +
> +		imx_ele_ocotp_grant_access(pdev, child);
> +	}
> +
> +	return 0;
> +}
> +
> +static int imx_ele_ocotp_access_control(struct platform_device *pdev)
> +{
> +	struct imx_ocotp_priv *priv = platform_get_drvdata(pdev);
> +	struct device_node *soc __free(device_node) = of_find_node_by_path("/soc");

No, you just created undocumented ABI on the name.

Drop/replace or express the ABI (which is impossible, so basically: drop).


Best regards,
Krzysztof