linux-kernel - Re: [RFC 3/5] powerpc: kvm: drop 32-bit book3s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b1ea054-22bb-4380-a1e4-8be988d8746d@csgroup.eu>
Date: Fri, 13 Dec 2024 09:02:19 +0100
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Arnd Bergmann <arnd@...nel.org>, kvm@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Huacai Chen <chenhuacai@...nel.org>, Jiaxun Yang <jiaxun.yang@...goat.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
 Naveen N Rao <naveen@...nel.org>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Alexander Graf <graf@...zon.com>, Crystal Wood <crwood@...hat.com>,
 Anup Patel <anup@...infault.org>, Atish Patra <atishp@...shpatra.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini
 <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
 "H. Peter Anvin" <hpa@...or.com>, Vitaly Kuznetsov <vkuznets@...hat.com>,
 David Woodhouse <dwmw2@...radead.org>, Paul Durrant <paul@....org>,
 Marc Zyngier <maz@...nel.org>, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 kvm-riscv@...ts.infradead.org, linux-riscv@...ts.infradead.org
Subject: Re: [RFC 3/5] powerpc: kvm: drop 32-bit book3s

Le 12/12/2024 à 13:55, Arnd Bergmann a écrit :
> From: Arnd Bergmann <arnd@...db.de>
> 
> Support for KVM on 32-bit Book III-s implementations was added in 2010
> and supports PowerMac, CHRP, and embedded platforms using the Freescale G4
> (mpc74xx), e300 (mpc83xx) and e600 (mpc86xx) CPUs from 2003 to 2009.
> 
> Earlier 603/604/750 machines might work but would be even more limited
> by their available memory.
> 
> The only likely users of KVM on any of these were the final Apple
> PowerMac/PowerBook/iBook G4 models with 2GB of RAM that were at the high
> end 20 years ago but are just as obsolete as their x86-32 counterparts.
> The code has been orphaned since 2023.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   MAINTAINERS                               |   2 +-
>   arch/powerpc/include/asm/kvm_book3s.h     |  19 ----
>   arch/powerpc/include/asm/kvm_book3s_asm.h |  10 --

pmac32_defconfig: something is going wrong with headers:

   CC      arch/powerpc/kernel/asm-offsets.s
In file included from ./arch/powerpc/include/asm/book3s/64/mmu-hash.h:20,
                  from ./arch/powerpc/include/asm/kvm_book3s_64.h:14,
                  from ./arch/powerpc/include/asm/kvm_book3s.h:380,
                  from ./arch/powerpc/include/asm/kvm_ppc.h:22,
                  from ./arch/powerpc/include/asm/dbell.h:17,
                  from arch/powerpc/kernel/asm-offsets.c:36:
./arch/powerpc/include/asm/book3s/64/pgtable.h:17: warning: "_PAGE_EXEC" 
redefined
    17 | #define _PAGE_EXEC              0x00001 /* execute permission */
       |
In file included from ./arch/powerpc/include/asm/book3s/pgtable.h:8,
                  from ./arch/powerpc/include/asm/pgtable.h:18,
                  from ./include/linux/pgtable.h:6,
                  from ./arch/powerpc/include/asm/kup.h:43,
                  from ./arch/powerpc/include/asm/uaccess.h:8,
                  from ./include/linux/uaccess.h:12,
                  from ./include/linux/sched/task.h:13,
                  from ./include/linux/sched/signal.h:9,
                  from ./include/linux/rcuwait.h:6,
                  from ./include/linux/percpu-rwsem.h:7,
                  from ./include/linux/fs.h:33,
                  from ./include/linux/compat.h:17,
                  from arch/powerpc/kernel/asm-offsets.c:12:
./arch/powerpc/include/asm/book3s/32/pgtable.h:30: note: this is the 
location of the previous definition
    30 | #define _PAGE_EXEC      0x200   /* software: exec allowed */
       |