linux-kernel - [PATCH V1] mm: fix bug in some memory information update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241213081618.53458-1-zhouzihan30@jd.com>
Date: Fri, 13 Dec 2024 16:16:19 +0800
From: zhouzihan30 <15645113830zzh@...il.com>
To: akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	zhouzihan30 <zhouzihan30@...com>,
	yaowenchao1 <yaowenchao@...com>
Subject: [PATCH V1] mm: fix bug in some memory information update

In the kernel, the zone's lowmem_reserve and _watermark, and the global
variable 'totalreserve_pages' depend on the value of managed_pages,
but after running adjust_managed_page_count, these values didn't updated,
which caused some problems.

For example, in a system with six 1GB large pages, we found that the value
of protection in zoneinfo (zone->lowmem_reserve), is not right.
Its value seems calculated from the initial managed_pages,
but after the managed_pages changed, was not updated. Only after reading
 the file /proc/sys/vm/lowmem_reserve_ratio, updates happen.

read file /proc/sys/vm/lowmem_reserve_ratio:

lowmem_reserve_ratio_sysctl_handler
----setup_per_zone_lowmem_reserve
--------calculate_totalreserve_pages

protection changed after reading file:

[root@...t ~]# cat /proc/zoneinfo | grep protection
        protection: (0, 2719, 57360, 0)
        protection: (0, 0, 54640, 0)
        protection: (0, 0, 0, 0)
        protection: (0, 0, 0, 0)
[root@...t ~]# cat /proc/sys/vm/lowmem_reserve_ratio
256     256     32      0
[root@...t ~]# cat /proc/zoneinfo | grep protection
        protection: (0, 2735, 63524, 0)
        protection: (0, 0, 60788, 0)
        protection: (0, 0, 0, 0)
        protection: (0, 0, 0, 0)

lowmem_reserve increased also makes the totalreserve_pages increased,
which causes a decrease in available memory. The one above is just a
 test machine, and the increase is not significant. On our online machine,
the reserved memory will increase by several GB due to reading this file.
It is clearly unreasonable to cause a sharp drop in available memory just
 by reading a file.

In this patch, we update reserve memory when update managed_pages, The
size of reserved memory becomes stable. But it seems that the _watermark
 should also be updated along with the managed_pages. We have not done
 it because we are unsure if it is reasonable to set the watermark through
 the initial managed_pages. If it is not reasonable, we will propose
 new patch.

Signed-off-by: zhouzihan30 <zhouzihan30@...com>
Signed-off-by: yaowenchao1 <yaowenchao@...com>
---
 mm/page_alloc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b6958333054d..b23e128afbcd 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5826,10 +5826,13 @@ __meminit void zone_pcp_init(struct zone *zone)
 			 zone->present_pages, zone_batchsize(zone));
 }

+static void setup_per_zone_lowmem_reserve(void);
+
 void adjust_managed_page_count(struct page *page, long count)
 {
 	atomic_long_add(count, &page_zone(page)->managed_pages);
 	totalram_pages_add(count);
+	setup_per_zone_lowmem_reserve();
 }
 EXPORT_SYMBOL(adjust_managed_page_count);

-- 
2.33.0