linux-kernel - Re: [PATCH 2/3] arm64: dts: qcom: ipq9574: Enable TRNG instead PRNG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93d9b6b3-0805-883f-33b2-1a5d8a384f99@quicinc.com>
Date: Fri, 13 Dec 2024 14:14:46 +0530
From: Md Sadre Alam <quic_mdalam@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, <andersson@...nel.org>,
        <konradybcio@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <quic_srichara@...cinc.com>, <quic_varada@...cinc.com>
Subject: Re: [PATCH 2/3] arm64: dts: qcom: ipq9574: Enable TRNG instead PRNG



On 12/13/2024 5:25 AM, Konrad Dybcio wrote:
> On 6.12.2024 8:20 AM, Md Sadre Alam wrote:
>> RNG hardware versions greater than 3.0 are Truly
>> Random Number Generators (TRNG). In IPQ95xx RNG
>> block is TRNG. Update the corresponding compatible
>> property to ensure the hardware block is registered
>> with the hw_random framework, which feeds the Linux
>> entropy pool.
> 
> Line wrapping should be around 72 chars, this looks funny
Ok
> 
> Please change the commit title to 'update TRNG compatible', as
> 'enable' implies the functionality is not present as of current.
Ok
> 
> The latter part of the last sentence is misleading, as both
> compatibles do the same thing in the driver. Instead, put emphasis
> on the wrong compatible being used and the patch making sure the
> hardware is described properly, without functional changes.
Ok, will update in next revision.
> 
> Same for patch 3
Ok
> 
> Konrad