linux-kernel - Re: [PATCH v2] media: ov5640: fix get_light

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1v2VRzgUVpHZvXR@kekkonen.localdomain>
Date: Fri, 13 Dec 2024 08:54:45 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Michal Simek <michal.simek@....com>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
	git@...inx.com, stable@...nel.org,
	Sam Bobrowicz <sam@...te-embedded.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Steve Longerbeam <slongerbeam@...il.com>,
	"open list:V4L2 CAMERA SENSOR DRIVERS" <linux-media@...r.kernel.org>
Subject: Re: [PATCH v2] media: ov5640: fix get_light_freq on auto

Hi Michal,

Thanks for the patch.

On Fri, Nov 22, 2024 at 09:28:01AM +0100, Michal Simek wrote:
> From: Sam Bobrowicz <sam@...te-embedded.com>
> 
> Light frequency was not properly returned when in auto
> mode and the detected frequency was 60Hz.
> 
> Fixes: 19a81c1426c1 ("[media] add Omnivision OV5640 sensor driver")
> Signed-off-by: Sam Bobrowicz <sam@...te-embedded.com>
> Signed-off-by: Michal Simek <michal.simek@....com>
> Cc: <stable@...nel.org>

Cc: stable@...r.kernel.org

And right after the Fixes: tag.

I fixed it this time.

> ---
> 
> Changes in v2:
> - add Fixes tag and cc stable
> 
>  drivers/media/i2c/ov5640.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index c1d3fce4a7d3..8566bc2edde9 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -1982,6 +1982,7 @@ static int ov5640_get_light_freq(struct ov5640_dev *sensor)
>  			light_freq = 50;
>  		} else {
>  			/* 60Hz */
> +			light_freq = 60;
>  		}
>  	}
>  

-- 
Regards,

Sakari Ailus