linux-kernel - Re: [PATCH] mm: add comments to do_mmap(), mmap_region() and vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0263af1-a2cb-4f3e-9654-549beba79732@lucifer.local>
Date: Fri, 13 Dec 2024 09:22:17 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: add comments to do_mmap(), mmap_region() and
 vm_mmap()

On Thu, Dec 12, 2024 at 06:36:04PM -0800, Andrew Morton wrote:
> On Thu, 12 Dec 2024 11:31:52 +0000 Lorenzo Stoakes <lorenzo.stoakes@...cle.com> wrote:
>
> > It isn't always entirely clear to users the difference between do_mmap(),
> > mmap_region() and vm_mmap(), so add comments to clarify what's going on in
> > each.
> >
> > This is compounded by the fact that we actually allow callers external to
> > mm to invoke both do_mmap() and mmap_region() (!), the latter of which is
> > really strictly speaking an internal memory mapping implementation detail.
>
> Thanks, the world just improved.

Thanks :)

This was one I promised somebody a while ago (sorry to whoever it was - I did go
look but couldn't find my mail...) - wrote it on my TODO - and so since I'm
winding down for the holidays and like to keep my promises thought it was about
time I tackled it :>)

>
> These functions have pretty dumb names.  Patches to give them more
> useful names would be small...
>

You're right, they are pretty incredibly dumb. Let me have a think on what would
make more sense here...